vala: Report error for async creation expression without yield

sailfishos-mirror · Nov 15, 2019 · 94bd762 · 94bd762
1 parent ab6fbac
commit 94bd762
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/tests/Makefile.am b/tests/Makefile.am
@@ -486,6 +486,7 @@ TESTS = \
 	asynchronous/bug793158.vala \
 	asynchronous/catch-error-scope.vala \
 	asynchronous/catch-in-finally.vala \
+	asynchronous/creation-missing-yield.test \
 	asynchronous/closures.vala \
 	asynchronous/finish-name.vala \
 	asynchronous/generator.vala \

diff --git a/tests/asynchronous/creation-missing-yield.test b/tests/asynchronous/creation-missing-yield.test
@@ -0,0 +1,10 @@
+Invalid Code
+
+class Foo {
+	public async Foo () {
+	}
+}
+
+void main () {
+	var foo = new Foo ();
+}
diff --git a/vala/valaobjectcreationexpression.vala b/vala/valaobjectcreationexpression.vala
@@ -365,6 +365,11 @@ public class Vala.ObjectCreationExpression : Expression {
 					error = true;
 					Report.error (source_reference, "yield expression not available outside async method");
 				}
+			} else if (m is CreationMethod) {
+				if (m.coroutine) {
+					error = true;
+					Report.error (source_reference, "missing `yield' before async creation expression");
+				}
 			}
 
 			// FIXME partial code duplication of MethodCall.check