Skip to content

Commit

Permalink
libsepol/cil: Use CIL_ERR for error messages in cil_compile()
Browse files Browse the repository at this point in the history
In cil_compile(), CIL_INFO is being used as the priority for
error messages. This can make it difficult to tell when the error
occurred.

Instead, use CIL_ERR as the priority for the error messages in
cil_compile().

Signed-off-by: James Carter <jwcart2@gmail.com>
  • Loading branch information
jwcart2 committed Apr 19, 2021
1 parent ca339eb commit 8314076
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions libsepol/cil/src/cil.c
Expand Up @@ -539,7 +539,7 @@ int cil_compile(struct cil_db *db)
cil_log(CIL_INFO, "Building AST from Parse Tree\n");
rc = cil_build_ast(db, db->parse->root, db->ast->root);
if (rc != SEPOL_OK) {
cil_log(CIL_INFO, "Failed to build ast\n");
cil_log(CIL_ERR, "Failed to build AST\n");
goto exit;
}

Expand All @@ -549,21 +549,21 @@ int cil_compile(struct cil_db *db)
cil_log(CIL_INFO, "Resolving AST\n");
rc = cil_resolve_ast(db, db->ast->root);
if (rc != SEPOL_OK) {
cil_log(CIL_INFO, "Failed to resolve ast\n");
cil_log(CIL_ERR, "Failed to resolve AST\n");
goto exit;
}

cil_log(CIL_INFO, "Qualifying Names\n");
rc = cil_fqn_qualify(db->ast->root);
if (rc != SEPOL_OK) {
cil_log(CIL_INFO, "Failed to qualify names\n");
cil_log(CIL_ERR, "Failed to qualify names\n");
goto exit;
}

cil_log(CIL_INFO, "Compile post process\n");
rc = cil_post_process(db);
if (rc != SEPOL_OK ) {
cil_log(CIL_INFO, "Post process failed\n");
cil_log(CIL_ERR, "Post process failed\n");
goto exit;
}

Expand Down

0 comments on commit 8314076

Please sign in to comment.