Skip to content

Commit

Permalink
libsepol/cil: Improve degenerate inheritance check
Browse files Browse the repository at this point in the history 
The commit 74d00a8 (libsepol/cil:
Detect degenerate inheritance and exit with an error) detects the
use of inheritance (mostly by the secilc-fuzzer and not in any real
policies) that results in the exponential growth of the policy through
the copying of blocks that takes place with inheritance in CIL.
Unfortunately, the check takes place during the pass when all the
blocks are being copied, so it is possible to consume all of a system's
memory before an error is produced.

The new check happens in two parts. First, a check is made while the
block inheritance is being linked to the block it will inherit. In
this check, all of the parent nodes of the inheritance rule up to the
root node are checked and if enough of these blocks are being inherited
(>= CIL_DEGENERATE_INHERITANCE_DEPTH), then a flag is set for a more
in-depth check after the pass. This in-depth check will determine the
number of potential inheritances that will occur when resolving the
all of the inheritance rules. If this value is greater than
CIL_DEGENERATE_INHERITANCE_GROWTH * the original number of inheritance
rules and greater than CIL_DEGENERATE_INHERITANCE_MINIMUM (which is
set to 0x1 << CIL_DEGENERATE_INHERITANCE_DEPTH), then degenerate
inheritance is determined to have occurred and an error result will
be returned.

Since the potential number of inheritances can quickly be an extremely
large number, the count of potential inheritances is aborted as soon
as the threshold for degenerate inheritance has been exceeded.

Normal policies should rarely, if ever, have the in-depth check occur.

Signed-off-by: James Carter <jwcart2@gmail.com>
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
  • Loading branch information
@jwcart2
jwcart2 committed Jun 24, 2021
1 parent 36e4945 commit 37863b0
Show file tree
Hide file tree
Showing 2 changed files with 151 additions and 80 deletions.
5 changes: 3 additions & 2 deletions libsepol/cil/src/cil_internal.h
View file
Expand Up @@ -48,8 +48,9 @@

#define CIL_MAX_NAME_LENGTH 2048

#define CIL_DEGENERATE_INHERITANCE_DEPTH 12
#define CIL_DEGENERATE_INHERITANCE_BREADTH (0x1 << CIL_DEGENERATE_INHERITANCE_DEPTH)
#define CIL_DEGENERATE_INHERITANCE_DEPTH 10UL
#define CIL_DEGENERATE_INHERITANCE_MINIMUM (0x01 << CIL_DEGENERATE_INHERITANCE_DEPTH)
#define CIL_DEGENERATE_INHERITANCE_GROWTH 10UL

enum cil_pass {
CIL_PASS_INIT = 0,
Expand Down
226 changes: 148 additions & 78 deletions libsepol/cil/src/cil_resolve_ast.c
View file
Expand Up @@ -64,6 +64,7 @@ struct cil_args_resolve {
struct cil_list *sensitivityorder_lists;
struct cil_list *in_list;
struct cil_stack *disabled_optionals;
int *inheritance_check;
};

static struct cil_name * __cil_insert_name(struct cil_db *db, hashtab_key_t key, struct cil_tree_node *ast_node)
Expand Down Expand Up @@ -2308,40 +2309,7 @@ int cil_resolve_sidcontext(struct cil_tree_node *current, void *extra_args)
return rc;
}

int cil_resolve_blockinherit_link(struct cil_tree_node *current, void *extra_args)
{
struct cil_blockinherit *inherit = current->data;
struct cil_symtab_datum *block_datum = NULL;
struct cil_tree_node *node = NULL;
int rc = SEPOL_ERR;

rc = cil_resolve_name(current, inherit->block_str, CIL_SYM_BLOCKS, extra_args, &block_datum);
if (rc != SEPOL_OK) {
goto exit;
}

node = NODE(block_datum);

if (node->flavor != CIL_BLOCK) {
cil_log(CIL_ERR, "%s is not a block\n", cil_node_to_string(node));
rc = SEPOL_ERR;
goto exit;
}

inherit->block = (struct cil_block *)block_datum;

if (inherit->block->bi_nodes == NULL) {
cil_list_init(&inherit->block->bi_nodes, CIL_NODE);
}
cil_list_append(inherit->block->bi_nodes, CIL_NODE, current);

return SEPOL_OK;

exit:
return rc;
}

void cil_print_recursive_blockinherit(struct cil_tree_node *bi_node, struct cil_tree_node *terminating_node)
static void cil_print_recursive_blockinherit(struct cil_tree_node *bi_node, struct cil_tree_node *terminating_node)
{
struct cil_list *trace = NULL;
struct cil_list_item *item = NULL;
Expand Down Expand Up @@ -2379,7 +2347,7 @@ void cil_print_recursive_blockinherit(struct cil_tree_node *bi_node, struct cil_
cil_list_destroy(&trace, CIL_FALSE);
}

int cil_check_recursive_blockinherit(struct cil_tree_node *bi_node)
static int cil_check_recursive_blockinherit(struct cil_tree_node *bi_node)
{
struct cil_tree_node *curr = NULL;
struct cil_blockinherit *bi = NULL;
Expand Down Expand Up @@ -2412,53 +2380,67 @@ int cil_check_recursive_blockinherit(struct cil_tree_node *bi_node)
return rc;
}

/*
* Detect degenerate inheritance of the form:
* ...
* (blockinherit ba)
* (block ba
* (block b1
* (blockinherit bb)
* )
* (block bb
* (block b2
* (blockinherit bc)
* )
* (block bc
* ...
*/
static int cil_check_for_degenerate_inheritance(struct cil_tree_node *current)
static int cil_possible_degenerate_inheritance(struct cil_tree_node *node)
{
struct cil_block *block = current->data;
struct cil_tree_node *node;
struct cil_list_item *item;
unsigned depth;
unsigned breadth = 0;
unsigned depth = 1;

cil_list_for_each(item, block->bi_nodes) {
breadth++;
}

if (breadth >= CIL_DEGENERATE_INHERITANCE_BREADTH) {
node = current->parent;
depth = 0;
while (node && node->flavor != CIL_ROOT) {
if (node->flavor == CIL_BLOCK) {
block = node->data;
if (block->bi_nodes != NULL) {
depth++;
node = node->parent;
while (node && node->flavor != CIL_ROOT) {
if (node->flavor == CIL_BLOCK) {
if (((struct cil_block *)(node->data))->bi_nodes != NULL) {
depth++;
if (depth >= CIL_DEGENERATE_INHERITANCE_DEPTH) {
return CIL_TRUE;
}
}
node = node->parent;
}
node = node->parent;
}

if (depth >= CIL_DEGENERATE_INHERITANCE_DEPTH) {
cil_tree_log(current, CIL_ERR, "Degenerate inheritance detected (depth=%u, breadth=%u)", depth, breadth);
return SEPOL_ERR;
}
return CIL_FALSE;
}

int cil_resolve_blockinherit_link(struct cil_tree_node *current, void *extra_args)
{
struct cil_args_resolve *args = extra_args;
struct cil_blockinherit *inherit = current->data;
struct cil_symtab_datum *block_datum = NULL;
struct cil_tree_node *node = NULL;
int rc = SEPOL_ERR;

rc = cil_resolve_name(current, inherit->block_str, CIL_SYM_BLOCKS, extra_args, &block_datum);
if (rc != SEPOL_OK) {
goto exit;
}

node = NODE(block_datum);

if (node->flavor != CIL_BLOCK) {
cil_log(CIL_ERR, "%s is not a block\n", cil_node_to_string(node));
rc = SEPOL_ERR;
goto exit;
}

inherit->block = (struct cil_block *)block_datum;

rc = cil_check_recursive_blockinherit(current);
if (rc != SEPOL_OK) {
goto exit;
}

if (inherit->block->bi_nodes == NULL) {
cil_list_init(&inherit->block->bi_nodes, CIL_NODE);
}
cil_list_append(inherit->block->bi_nodes, CIL_NODE, current);

if (*(args->inheritance_check) == CIL_FALSE) {
*(args->inheritance_check) = cil_possible_degenerate_inheritance(node);
}

return SEPOL_OK;

exit:
return rc;
}

int cil_resolve_blockinherit_copy(struct cil_tree_node *current, void *extra_args)
Expand All @@ -2477,11 +2459,6 @@ int cil_resolve_blockinherit_copy(struct cil_tree_node *current, void *extra_arg

db = args->db;

rc = cil_check_for_degenerate_inheritance(current);
if (rc != SEPOL_OK) {
goto exit;
}

// Make sure this is the original block and not a merged block from a blockinherit
if (current != block->datum.nodes->head->data) {
rc = SEPOL_OK;
Expand Down Expand Up @@ -3597,6 +3574,88 @@ int cil_resolve_userattributeset(struct cil_tree_node *current, void *extra_args
return rc;
}

/*
* Degenerate inheritance leads to exponential growth of the policy
* It can take many forms, but here is one example.
* ...
* (blockinherit ba)
* (block b0
* (block b1
* (block b2
* (block b3
* ...
* )
* (blockinherit b3)
* )
* (blockinherit b2)
* )
* (blockinherit b1)
* )
* (blockinherit b0)
* ...
* This leads to 2^4 copies of the content of block b3, 2^3 copies of the
* contents of block b2, etc.
*/
static unsigned cil_count_actual(struct cil_tree_node *node)
{
unsigned count = 0;

if (node->flavor == CIL_BLOCKINHERIT) {
count += 1;
}

for (node = node->cl_head; node; node = node->next) {
count += cil_count_actual(node);
}

return count;
}

static unsigned cil_count_potential(struct cil_tree_node *node, unsigned max)
{
unsigned count = 0;

if (node->flavor == CIL_BLOCKINHERIT) {
struct cil_blockinherit *bi = node->data;
count += 1;
if (bi->block) {
count += cil_count_potential(NODE(bi->block), max);
if (count > max) {
return count;
}
}
}

for (node = node->cl_head; node; node = node->next) {
count += cil_count_potential(node, max);
if (count > max) {
return count;
}
}

return count;
}

static int cil_check_for_degenerate_inheritance(struct cil_tree_node *node)
{
uint64_t num_actual, num_potential, max;

num_actual = cil_count_actual(node);

max = num_actual * CIL_DEGENERATE_INHERITANCE_GROWTH;
if (max < CIL_DEGENERATE_INHERITANCE_MINIMUM) {
max = CIL_DEGENERATE_INHERITANCE_MINIMUM;
}

num_potential = cil_count_potential(node, max);

if (num_potential > max) {
return SEPOL_ERR;
}

return SEPOL_OK;
}

int __cil_resolve_ast_node(struct cil_tree_node *node, void *extra_args)
{
int rc = SEPOL_OK;
Expand Down Expand Up @@ -4068,6 +4127,7 @@ int cil_resolve_ast(struct cil_db *db, struct cil_tree_node *current)
struct cil_args_resolve extra_args;
enum cil_pass pass = CIL_PASS_TIF;
uint32_t changed = 0;
int inheritance_check = 0;

if (db == NULL || current == NULL) {
return rc;
Expand All @@ -4087,6 +4147,7 @@ int cil_resolve_ast(struct cil_db *db, struct cil_tree_node *current)
extra_args.sensitivityorder_lists = NULL;
extra_args.in_list = NULL;
extra_args.disabled_optionals = NULL;
extra_args.inheritance_check = &inheritance_check;

cil_list_init(&extra_args.to_destroy, CIL_NODE);
cil_list_init(&extra_args.sidorder_lists, CIL_LIST_ITEM);
Expand All @@ -4113,6 +4174,15 @@ int cil_resolve_ast(struct cil_db *db, struct cil_tree_node *current)
cil_list_destroy(&extra_args.in_list, CIL_FALSE);
}

if (pass == CIL_PASS_BLKIN_LINK && inheritance_check == CIL_TRUE) {
rc = cil_check_for_degenerate_inheritance(current);
if (rc != SEPOL_OK) {
cil_log(CIL_ERR, "Degenerate inheritance detected\n");
rc = SEPOL_ERR;
goto exit;
}
}

if (pass == CIL_PASS_MISC1) {
db->sidorder = __cil_ordered_lists_merge_all(&extra_args.sidorder_lists, NULL);
if (db->sidorder == NULL) {
Expand Down

0 comments on commit 37863b0

Please sign in to comment.