Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sailfishos-mirror/qtbase
base: 82063d9af1f9ad6cddab4d5526316816cbe1a77c
Choose a base ref
...
head repository: sailfishos-mirror/qtbase
compare: 1015919e8e828f886fbd15e7929fb634363ddc35
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on Jun 30, 2021

  1. Port QSettingsPrivate::get() to std::optional

    ... instead of a bool return and a QVariant out parameter.
    
    Change-Id: I9d937668ede668075d1de5bb57f61e4c260aaddc
    Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
    Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
    marc-kdab committed Jun 30, 2021
    Copy the full SHA
    c587ebf View commit details
    Browse the repository at this point in the history
  2. QWinSettings: port readKey() helper to std::optional

    Less boilerplate code and no more impedance mismatch with
    recently-ported QSettingsPrivate::get().
    
    Change-Id: I5e113a44a48274aecb20fc9cb5d8db02c6cd0a35
    Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
    Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
    marc-kdab committed Jun 30, 2021
    Copy the full SHA
    f3c9200 View commit details
    Browse the repository at this point in the history
  3. Add Qt7 TODOs for reducing the size of QColor

    It could fit into QVariant's inline storage if we didn't waste so much
    space.
    
    Change-Id: Ie9e592a49c955b0a97a202e0bd875183396af993
    Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
    Ulf Hermann committed Jun 30, 2021
    Copy the full SHA
    1015919 View commit details
    Browse the repository at this point in the history