• Daniel Lenski's avatar
    command-line client should fill in any password field with value supplied via --passwd-on-stdin · b6dc8211
    Daniel Lenski authored
    I previously proposed adding form field hints to suggest which fields should
    be populated with username/password values.  David Woodhouse was hesitant to
    accept this and we settled on matching the form field names by the first
    four characters ("user", "pass") as a temporary compromise:
    
        http://lists.infradead.org/pipermail/openconnect-devel/2017-August/004458.html
    
    There's at least one specific case where this interferes with the
    usage of the command-line client: some GlobalProtect users need to
    specify an "alternative secret field" instead of the default "passwd"
    field (using `--usergroup :field_name`).
    
    Because this field's name normally doesn't start with "pass", openconnect
    won't accept it via `--passwd-on-stdin`:
    
        script_to_do_fancy_GlobalProtect_SAML_login |
          openconnect --protocol=gp -u user --passwd-on-stdin --usergroup portal:portal_cookie_field_name globalprotect.company.com
    
    As far as I can tell, there's not actually any good reason why openconnect
    should *only* fill in a password-type field with the supplied password
    if its name starts with "pass", so we should get rid of that check.
    Signed-off-by: default avatarDaniel Lenski <dlenski@gmail.com>
    b6dc8211
Name
Last commit
Last update
android Loading commit data...
java Loading commit data...
m4 Loading commit data...
po Loading commit data...
tests Loading commit data...
www Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
AUTHORS Loading commit data...
COPYING.LGPL Loading commit data...
Makefile.am Loading commit data...
README.DTLS Loading commit data...
README.TESTS Loading commit data...
TODO Loading commit data...
acinclude.m4 Loading commit data...
auth-common.c Loading commit data...
auth-globalprotect.c Loading commit data...
auth-juniper.c Loading commit data...
auth.c Loading commit data...
autogen.sh Loading commit data...
compat.c Loading commit data...
config.rpath Loading commit data...
configure.ac Loading commit data...
csd-post.sh Loading commit data...
csd-wrapper.sh Loading commit data...
cstp.c Loading commit data...
digest.c Loading commit data...
dtls.c Loading commit data...
esp-seqno.c Loading commit data...
esp.c Loading commit data...
gnutls-dtls.c Loading commit data...
gnutls-esp.c Loading commit data...
gnutls.c Loading commit data...
gnutls.h Loading commit data...
gnutls_tpm.c Loading commit data...
gpst.c Loading commit data...
gssapi.c Loading commit data...
hipreport.sh Loading commit data...
http-auth.c Loading commit data...
http.c Loading commit data...
iconv.c Loading commit data...
jni.c Loading commit data...
libopenconnect.map.in Loading commit data...
library.c Loading commit data...
lzo.c Loading commit data...
lzo.h Loading commit data...
lzs.c Loading commit data...
main.c Loading commit data...
mainloop.c Loading commit data...
ntlm.c Loading commit data...
oath.c Loading commit data...
oncp.c Loading commit data...
openconnect-internal.h Loading commit data...
openconnect.8.in Loading commit data...
openconnect.h Loading commit data...
openconnect.ico Loading commit data...
openconnect.pc.in Loading commit data...
openconnect.rc Loading commit data...
openssl-dtls.c Loading commit data...
openssl-esp.c Loading commit data...
openssl-pkcs11.c Loading commit data...
openssl.c Loading commit data...
script.c Loading commit data...
ssl.c Loading commit data...
sspi.c Loading commit data...
stoken.c Loading commit data...
tncc-wrapper.py Loading commit data...
tun-win32.c Loading commit data...
tun.c Loading commit data...
version.sh Loading commit data...
win32-ipicmp.h Loading commit data...
xml.c Loading commit data...
yubikey.c Loading commit data...