With --user, enter username in all forms, not just the first

See merge request openconnect/openconnect!220

Signed-off-by: Daniel Lenski <dlenski@gmail.com>

Until now, the -u/--user=USERNAME option has caused the OpenConnect CLI to
automatically fill the username only in the *first* form where there is a
match field.  This patch causes it to fill the username repeatedly
(including when a form is repeated due to an authentication failure).

As described by @DimitriPapadopoulos in #267:

> In many cases, I expect the authentication failure to be caused by an
> incorrect password, not an incorrect username
>
> Having to [re]enter the username, when it has already been specified from
> the command line or worse in a config file, is an annoyance.  I suggest
> openconnect [re]prompts for the username only when it has been entered
> interactively from the start.
Signed-off-by: Daniel Lenski <dlenski@gmail.com>

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

Pass the `portal-*cookie` values received in the portal config to the gateway login

Closes #147

See merge request openconnect/openconnect!199

http: Allow passing header_cb to do_https_request

See merge request openconnect/openconnect!201

Docs should link to Gitlab as the main repository for vpnc-script and vpnc-script-win.js

See merge request openconnect/openconnect!213

Fix Linux kernel coding style errors and warnings reported by checkpatch.pl

See merge request openconnect/openconnect!212

Follow disable_ipv6 for Pulse and Fortinet

See merge request openconnect/openconnect!214

small PPP fixes

See merge request openconnect/openconnect!216

update --authenticate docs to explain $RESOLVE and $CONNECT_URL

See merge request openconnect/openconnect!219

Fix URL of repository of vpnc-script

See merge request openconnect/openconnect!227

Error reported by checkpatch.pl.
Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Warnings by checkpatch.pl.
I have learned something today:
https://eklitzke.org/c-functions-without-argumentsSigned-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Warnings by checkpatch.pl.
I have fixed actual errors and left actual conscious decisions.
Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

Mention the CONNECT_URL and RESOLVE options, and how to use them to invoke
the connection phase in the maximally-robust way (which should work for all
protocols, and all possible proxies).
Signed-off-by: Daniel Lenski <dlenski@gmail.com>

Signed-off-by: Daniel Lenski <dlenski@gmail.com>

I see malloc/free showing up at ~5% of perf traces, and it's entirely
pointless when we could be reusing packets.

This trick isn't *perfect* and there's potential for a pathological
case where all the packets on the free_queue are too small to be
reused but we never get rid of them anyway — but rounding up to 2KiB
should mean that never happens in practice, and the alignment we get
from that rounding probably doesn't hurt performance anyway.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

We have an explicit select() call on the cmd_fd even when we're busy
shovelling packets and never hit the main select() in the mainloop.
This is *just* to ensure that we react to a cancel command quickly.

In the *common* case that we're running in openconnect(8), there's no
need for that since the *only* thing that will write to the cmd_fd is
openconnect itself, and *that* can set a flag in memory to tell us to
look.

So implement that optimisation — don't check it each time around the
mainloop unless the vpninfo->need_poll_cmd_fd flag is set. That flag
is set whenever we have written to cmd_fd and there's something to be
read. And cleared by poll_cmd_fd() when it runs and finds nothing there.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

Get rid of trailing spaces

See merge request openconnect/openconnect!217

We have pulled commit 004b582 from 14 May 2016.

Tests have been moved to a different file, so the file is smaller.
I have kept local changes, except the removal of INT_MAX -1000.
Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Update m4 files

See merge request openconnect/openconnect!225

Remove assert

See merge request openconnect/openconnect!223

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

http:// -> https://

See merge request openconnect/openconnect!211

m4/ax_check_vscript.m4
  the latest version from the Autoconf Archive

m4/iconv.m4
  the latest version from gnulib still compatible with autoconf 2.62

m4/lib-ld.m4
m4/lib-link.m4
m4/lib-prefix.m4
  the latest versions from gnulib
Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

I have left out:
- sites that have not moved to HTTPS
- URLs found in XML and SVG files
Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

ise → ize

Closes #268

See merge request openconnect/openconnect!221

Add option to read server name from config file

Closes #261 and #171

See merge request openconnect/openconnect!218