fix undefined pointer error from !143

Caught by static analyzer run. Signed-off-by: Daniel Lenski <dlenski@gmail.com>
sailfishos-mirror · Nov 30, 2020 · dc1f764 · dc1f764
1 parent 6bcdf4e
commit dc1f764
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/auth-globalprotect.c b/auth-globalprotect.c
@@ -328,6 +328,9 @@ static int parse_login_xml(struct openconnect_info *vpninfo, xmlNode *xml_node,
 		while (xml_node && xml_node->type != XML_ELEMENT_NODE)
 			xml_node = xml_node->next;
 
+		/* XX: argument 0 is unknown so we reuse this for extra arguments */
+		arg = &gp_login_args[(argn < gp_login_nargs) ? argn : 0];
+
 		if (!xml_node)
 			value = NULL;
 		else if (!xmlnode_get_val(xml_node, "argument", &value)) {
@@ -348,9 +351,6 @@ static int parse_login_xml(struct openconnect_info *vpninfo, xmlNode *xml_node,
 		} else
 			goto err_out;
 
-		/* XX: argument 0 is unknown so we reuse this for extra arguments */
-		arg = &gp_login_args[(argn < gp_login_nargs) ? argn : 0];
-
 		if (arg->unknown && value) {
 			unknown_args++;
 			vpn_progress(vpninfo, PRG_ERR,