Navigation Menu

Skip to content

Commit

Permalink
use recv() and closesocket() on the cmd_fd on windows
Browse files Browse the repository at this point in the history
[dwmw2: Reduce #ifdefs by using recv() everywhere, not just on Windows]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Nikos Mavrogiannopoulos authored and David Woodhouse committed Sep 15, 2014
1 parent 714c740 commit caf8deb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions library.c
Expand Up @@ -151,8 +151,8 @@ void openconnect_vpninfo_free(struct openconnect_info *vpninfo)
openconnect_close_https(vpninfo, 1);
dtls_shutdown(vpninfo);
if (vpninfo->cmd_fd_write != -1) {
close(vpninfo->cmd_fd);
close(vpninfo->cmd_fd_write);
closesocket(vpninfo->cmd_fd);
closesocket(vpninfo->cmd_fd_write);
}

#ifdef HAVE_ICONV
Expand Down Expand Up @@ -454,8 +454,8 @@ OPENCONNECT_CMD_SOCKET openconnect_setup_cmd_pipe(struct openconnect_info *vpnin
#endif

if (set_sock_nonblock(pipefd[0]) || set_sock_nonblock(pipefd[1])) {
close(pipefd[0]);
close(pipefd[1]);
closesocket(pipefd[0]);
closesocket(pipefd[1]);
return CMD_PIPE_ERR;
}
vpninfo->cmd_fd = pipefd[0];
Expand Down
2 changes: 1 addition & 1 deletion ssl.c
Expand Up @@ -628,7 +628,7 @@ void check_cmd_fd(struct openconnect_info *vpninfo, fd_set *fds)
return;
}

if (read(vpninfo->cmd_fd, &cmd, 1) != 1)
if (recv(vpninfo->cmd_fd, &cmd, 1, 0) != 1)
return;

switch (cmd) {
Expand Down

0 comments on commit caf8deb

Please sign in to comment.