Fix buffer overrun in useragent. Use asprintf

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
sailfishos-mirror · Dec 7, 2009 · a1e1686 · a1e1686
1 parent 3faf371
commit a1e1686
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/http.c b/http.c
@@ -628,7 +628,10 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
 
 char *openconnect_create_useragent(char *base)
 {
-	char *uagent = malloc(strlen(base) + 1 + strlen(openconnect_version));
-	sprintf(uagent, "%s %s", base, openconnect_version);
+	char *uagent;
+
+	if (asprintf(&uagent, "%s %s", base, openconnect_version) < 0)
+		return NULL;
+
 	return uagent;
 }