Merge branch 'less_confusing_output_when_authentication_fails' into '…

…master'

less confusing output when authentication fails

See merge request openconnect/openconnect!146

auth-globalprotect.c

@@ -124,7 +124,8 @@ static int parse_prelogin_xml(struct openconnect_info *vpninfo, xmlNode *xml_nod
 				             saml_method);
 			vpn_progress(vpninfo, PRG_ERR,
 			             _("When SAML authentication is complete, specify destination form field by appending :field_name to login URL.\n"));
-			result = -EINVAL;
+                       /* XX: EINVAL will lead to "failure to parse response", with unnecessary/confusing extra logging output */
+			result = -EPERM;
 			goto out;
 		} else
 			vpn_progress(vpninfo, PRG_DEBUG, _("Destination form field %s was specified; assuming SAML %s authentication is complete.\n"),

main.c

@@ -1893,7 +1893,7 @@ int main(int argc, char **argv)
 			unlink(vpninfo->csd_scriptname);
 			vpninfo->csd_scriptname = NULL;
 		}
-		fprintf(stderr, _("Failed to obtain WebVPN cookie\n"));
+		fprintf(stderr, _("Failed to complete authentication\n"));
 		exit(1);
 	}