Skip to content

Commit

Permalink
Update comment about own HTTP implementation
Browse files Browse the repository at this point in the history
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Jan 14, 2016
1 parent e41e201 commit 81d698a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions http.c
Expand Up @@ -813,13 +813,13 @@ int do_https_request(struct openconnect_info *vpninfo, const char *method,
}

/*
* It would be nice to use cURL for this, but we really need to guarantee
* that we'll be using OpenSSL (for the TPM stuff), and it doesn't seem
* to have any way to let us provide our own socket read/write functions.
* We can only provide a socket _open_ function. Which would require having
* a socketpair() and servicing the "other" end of it.
* A long time ago, I *wanted* to use an HTTP client library like cURL
* for this. But we need a *lot* of control over the underlying SSL
* transport, and we also have to do horrid tricks like the Juniper NC
* 'GET' request that actaully behaves like a 'CONNECT'.
*
* So the world gained Yet Another HTTP Implementation. Sorry.
*
* So we process the HTTP for ourselves...
*/
buf_truncate(buf);
buf_append(buf, "%s /%s HTTP/1.1\r\n", method, vpninfo->urlpath ?: "");
Expand Down

0 comments on commit 81d698a

Please sign in to comment.