Skip to content

Commit

Permalink
Don't split translated strings with #ifdefs
Browse files Browse the repository at this point in the history
It makes the translators hunt you down and hurt you. And while they're
hurting you, they shout at you in multiple languages that you don't
understand.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
dwmw2 committed Mar 30, 2020
1 parent f63d0e7 commit 5a36dc4
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions main.c
Expand Up @@ -1507,15 +1507,17 @@ int main(int argc, char **argv)
#endif
case OPT_CIPHERSUITES:
fprintf(stderr,
#ifdef OPENCONNECT_GNUTLS
_("WARNING: You specified --gnutls-priority. This should not be\n"
_("WARNING: You specified %s. This should not be\n"
" necessary; please report cases where a priority string\n"
" override is necessary to connect to a server\n"
" to <openconnect-devel@lists.infradead.org>.\n"),
#ifdef OPENCONNECT_GNUTLS
"--gnutls-priority"
#elif defined(OPENCONNECT_OPENSSL)
_("WARNING: You specified --openssl-ciphers. This should not be\n"
" necessary; please report cases where a cipher list\n"
"--openssl-ciphers"
#endif
" override is necessary to connect to a server\n"
" to <openconnect-devel@lists.infradead.org>.\n"));
);

strncpy(vpninfo->ciphersuite_config, config_arg, sizeof(vpninfo->ciphersuite_config) - 1);
break;
default:
Expand Down

0 comments on commit 5a36dc4

Please sign in to comment.