Skip to content

Commit

Permalink
Don't segfault when search domain list is empty (and thus `domains->p…
Browse files Browse the repository at this point in the history
…os == 0`)

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
  • Loading branch information
dlenski authored and dwmw2 committed Oct 6, 2018
1 parent 6d72123 commit 4746208
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gpst.c
Expand Up @@ -509,7 +509,7 @@ static int gpst_parse_config_xml(struct openconnect_info *vpninfo, xmlNode *xml_
for (member = xml_node->children; member; member=member->next)
if (!xmlnode_get_val(member, "member", &s))
buf_append(domains, "%s ", s);
if (buf_error(domains) == 0) {
if (buf_error(domains) == 0 && domains->pos > 0) {
domains->data[domains->pos-1] = '\0';
vpninfo->ip_info.domain = add_option(vpninfo, "search", &domains->data);
}
Expand Down

0 comments on commit 4746208

Please sign in to comment.