Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Kill auth_is_proxy() abomination in ntlm.c
In commit 70dd287 ("Fix some more proxy assumptions in HTTP auth") I introduced a horrible auth_is_proxy() macro into ntlm.c, doing invalid pointer comparisons with pointers which weren't necessarily from the same array. And casting them to 'unsigned long', which thankfully caused a warning on the Win64 build and made me take another look. I was just being horrifically lazy and stupid. The correct fix is to pass the 'proxy' argument down through the call stack from the ntlm_authorization() function to the places where we care. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
- Loading branch information
David Woodhouse
authored and
David Woodhouse
committed
Oct 6, 2015
1 parent
227fb87
commit 283e8c3
Showing
1 changed file
with
22 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters