Forbid pointless http_add_cookie() with value==NULL and !replace

Coverity doesn't like it, because it would lead to dereferencing a NULL pointer. It should never happen, since it's meaningless. So explicitly return -EINVAL. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
sailfishos-mirror · Feb 28, 2015 · 21918c3 · 21918c3
1 parent cb84498
commit 21918c3
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/http.c b/http.c
@@ -308,6 +308,9 @@ int http_add_cookie(struct openconnect_info *vpninfo, const char *option,
 	} else {
 		/* Kill cookie; don't replace it */
 		new = NULL;
+		/* This would be meaningless */
+		if (!replace)
+			return -EINVAL;
 	}
 	for (this = &vpninfo->cookies; *this; this = &(*this)->next) {
 		if (!strcmp(option, (*this)->option)) {