Navigation Menu

Skip to content

Commit

Permalink
With --user, enter username in all forms, not just the first
Browse files Browse the repository at this point in the history
Until now, the -u/--user=USERNAME option has caused the OpenConnect CLI to
automatically fill the username only in the *first* form where there is a
match field.  This patch causes it to fill the username repeatedly
(including when a form is repeated due to an authentication failure).

As described by @DimitriPapadopoulos in #267:

> In many cases, I expect the authentication failure to be caused by an
> incorrect password, not an incorrect username
>
> Having to [re]enter the username, when it has already been specified from
> the command line or worse in a config file, is an annoyance.  I suggest
> openconnect [re]prompts for the username only when it has been entered
> interactively from the start.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
  • Loading branch information
dlenski committed Jun 29, 2021
1 parent 2d75177 commit 193aa75
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions main.c
Expand Up @@ -2614,8 +2614,7 @@ static int process_auth_form_cb(void *_vpninfo,
if (username &&
(!strncasecmp(opt->name, "user", 4) ||
!strncasecmp(opt->name, "uname", 5))) {
opt->_value = username;
username = NULL;
opt->_value = strdup(username);
} else {
opt->_value = saved_form_field(vpninfo, form->auth_id, opt->name);
if (!opt->_value)
Expand Down

0 comments on commit 193aa75

Please sign in to comment.