Avoid retrying without XML POST when we didn't even manage to connect

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

http.c

@@ -960,7 +960,11 @@ static int do_https_request(struct openconnect_info *vpninfo, const char *method
 				     _("Failed to open HTTPS connection to %s\n"),
 				     vpninfo->hostname);
 			buf_free(buf);
-			return result;
+			/* We really don't want to return -EINVAL if we have
+			   failed to even connect to the server, because if
+			   we do that openconnect_obtain_cookie() might try
+			   again without XMLPOST... with the same result. */
+			return -EIO;
 		}
 	}
 

www/changelog.xml

@@ -15,6 +15,7 @@
 <ul>
    <li><b>OpenConnect HEAD</b>
      <ul>
+       <li>Avoid retrying without XML POST, when we failed to even reach the server.</li>
        <li>Fix off-by-one in parameter substitution in error messages.</li>
        <li>Improve reporting when GSSAPI auth requested but not compiled in.</li>
        <li>Fix parsing of split include routes on Windows.</li>