Fix leak of PKCS#11 object ID on URI parse failure

Spotted by Coverity. Signed-off-by: David Woodhouse <dwmw2@infradead.org>
sailfishos-mirror · Oct 9, 2019 · 0f8ebd1 · 0f8ebd1
1 parent a200362
commit 0f8ebd1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/openssl-pkcs11.c b/openssl-pkcs11.c
@@ -115,6 +115,8 @@ static int parse_pkcs11_uri(const char *uri, PKCS11_TOKEN **p_tok,
 		return -ENOMEM;
 	}
 
+	*id = NULL;
+
 	/* We are only ever invoked if the string starts with 'pkcs11:' */
 	end = uri + 6;
 	while (!ret && end[0] && end[1]) {
@@ -172,6 +174,8 @@ static int parse_pkcs11_uri(const char *uri, PKCS11_TOKEN **p_tok,
 		free(tok);
 		tok = NULL;
 		free(newlabel);
+		free(*id);
+		*id = NULL;
 	}
 
 	return ret;