fix <select>/<option> parsing bug

The Juniper form-handling code was setting <select>/<option> labels
identically to their values.

Presumably, this was never caught before because they never actually differ
in real Juniper login forms? (but they do in F5 forms)

That is, a Juniper <option> field always looks like…

    <select name="realm">
      <option value="Something">Something</option>
      <option value="Another">Another</option>
    </select>

… and never like this:

    <select name="realm">
      <option value="group1">Something</option>
      <option value="group2">Another</option>
    </select>

Signed-off-by: Daniel Lenski <dlenski@gmail.com>

auth-html.c

@@ -170,9 +170,8 @@ int parse_select_node(struct openconnect_info *vpninfo, struct oc_auth_form *for
 			return -ENOMEM;
 		}
 
-		xmlnode_get_prop(node, "name", &choice->name);
+		xmlnode_get_prop(child, "value", &choice->name);
 		choice->label = (char *)xmlNodeGetContent(child);
-		choice->name = strdup(choice->label);
 		new_choices = realloc(opt->choices, sizeof(opt->choices[0]) * (opt->nr_choices+1));
 		if (!new_choices) {
 			free_opt((void *)opt);