• David Woodhouse's avatar
    Kill auth_is_proxy() abomination in ntlm.c · 283e8c32
    David Woodhouse authored
    In commit 70dd287c ("Fix some more proxy assumptions in HTTP auth") I
    introduced a horrible auth_is_proxy() macro into ntlm.c, doing invalid
    pointer comparisons with pointers which weren't necessarily from the same
    array. And casting them to 'unsigned long', which thankfully caused a
    warning on the Win64 build and made me take another look.
    I was just being horrifically lazy and stupid. The correct fix is to
    pass the 'proxy' argument down through the call stack from the
    ntlm_authorization() function to the places where we care.
    Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
ntlm.c 31.7 KB