• Kevin Jacobs's avatar
    Bug 1690583 - Fix CH padding extension size calculation. r=mt · 1b6a8571
    Kevin Jacobs authored
    Bug 1654332 changed the way that NSS constructs Client Hello messages. `ssl_CalculatePaddingExtLen` now receives a `clientHelloLength` value that includes the 4B handshake header. This looks okay per the inline comment (which states that only the record header is omitted from the length), but the function actually assumes that the handshake header is also omitted.
    
    This patch removes the addition of the handshake header length. Those bytes are already included in the buffered CH.
    
    Differential Revision: https://phabricator.services.mozilla.com/D103934
    
    --HG--
    extra : moz-landing-system : lando
    1b6a8571
Name
Last commit
Last update
..
Makefile Loading commit data...
bloomfilter_unittest.cc Loading commit data...
gtest_utils.h Loading commit data...
libssl_internals.c Loading commit data...
libssl_internals.h Loading commit data...
manifest.mn Loading commit data...
rsa8193.h Loading commit data...
selfencrypt_unittest.cc Loading commit data...
ssl_0rtt_unittest.cc Loading commit data...
ssl_aead_unittest.cc Loading commit data...
ssl_agent_unittest.cc Loading commit data...
ssl_auth_unittest.cc Loading commit data...
ssl_cert_ext_unittest.cc Loading commit data...
ssl_cipherorder_unittest.cc Loading commit data...
ssl_ciphersuite_unittest.cc Loading commit data...
ssl_custext_unittest.cc Loading commit data...
ssl_damage_unittest.cc Loading commit data...
ssl_debug_env_unittest.cc Loading commit data...
ssl_dhe_unittest.cc Loading commit data...
ssl_drop_unittest.cc Loading commit data...
ssl_ecdh_unittest.cc Loading commit data...
ssl_ems_unittest.cc Loading commit data...
ssl_exporter_unittest.cc Loading commit data...
ssl_extension_unittest.cc Loading commit data...
ssl_fragment_unittest.cc Loading commit data...
ssl_fuzz_unittest.cc Loading commit data...
ssl_gather_unittest.cc Loading commit data...
ssl_gtest.cc Loading commit data...
ssl_gtest.gyp Loading commit data...
ssl_hrr_unittest.cc Loading commit data...
ssl_keylog_unittest.cc Loading commit data...
ssl_keyupdate_unittest.cc Loading commit data...
ssl_loopback_unittest.cc Loading commit data...
ssl_masking_unittest.cc Loading commit data...
ssl_misc_unittest.cc Loading commit data...
ssl_record_unittest.cc Loading commit data...
ssl_recordsep_unittest.cc Loading commit data...
ssl_recordsize_unittest.cc Loading commit data...
ssl_renegotiation_unittest.cc Loading commit data...
ssl_resumption_unittest.cc Loading commit data...
ssl_skip_unittest.cc Loading commit data...
ssl_staticrsa_unittest.cc Loading commit data...
ssl_tls13compat_unittest.cc Loading commit data...
ssl_v2_client_hello_unittest.cc Loading commit data...
ssl_version_unittest.cc Loading commit data...
ssl_versionpolicy_unittest.cc Loading commit data...
test_io.cc Loading commit data...
test_io.h Loading commit data...
tls_agent.cc Loading commit data...
tls_agent.h Loading commit data...
tls_connect.cc Loading commit data...
tls_connect.h Loading commit data...
tls_ech_unittest.cc Loading commit data...
tls_filter.cc Loading commit data...
tls_filter.h Loading commit data...
tls_hkdf_unittest.cc Loading commit data...
tls_protect.cc Loading commit data...
tls_protect.h Loading commit data...
tls_psk_unittest.cc Loading commit data...
tls_subcerts_unittest.cc Loading commit data...