• Martin Thomson's avatar
    Bug 1489945 - Handle second ticket with external ticket caching, r=franziskus · 74bce7bb
    Martin Thomson authored
    Summary:
    If we get a second session ticket in TLS 1.3 (as boringssl is wont to
    do, and maybe others) while the external session cache is enabled, we assert.
    The fix is to stop assuming that only in_client_cache sessions have a ticket
    attached.  The bigger fix ensures that sessions are properly labelled so that we
    correctly create a new session in the event that we get multiple tickets from a
    server.
    
    I *think* that this isn't that high a priority.  Michal is apparently working on
    code related to this, but should still be able to make progress by disabling TLS
    1.3 (or avoiding boringSSL servers).
    
    Reviewers: franziskus, ekr
    
    Reviewed By: franziskus
    
    Bug #: 1489945
    
    Differential Revision: https://phabricator.services.mozilla.com/D5740
    
    --HG--
    extra : rebase_source : 5203e4275b86605cf71662c2abd4fe58ec8b560c
    extra : amend_source : ad8290b441bee98fb5fe3615c0c96f4fe2e41d6c
    74bce7bb
Name
Last commit
Last update
automation Loading commit data...
cmd Loading commit data...
coreconf Loading commit data...
cpputil Loading commit data...
doc Loading commit data...
fuzz Loading commit data...
gtests Loading commit data...
lib Loading commit data...
nss-tool Loading commit data...
pkg Loading commit data...
tests Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.hgignore Loading commit data...
.hgtags Loading commit data...
.sancov-blacklist Loading commit data...
.taskcluster.yml Loading commit data...
COPYING Loading commit data...
Makefile Loading commit data...
build.sh Loading commit data...
exports.gyp Loading commit data...
help.txt Loading commit data...
mach Loading commit data...
manifest.mn Loading commit data...
nss.gyp Loading commit data...
readme.md Loading commit data...
trademarks.txt Loading commit data...