• David Keeler's avatar
    Bug 1363932 - reduce locking overhead in sftk_searchObjectList r=franziskus · 477cca58
    David Keeler authored
    Summary:
    Before this patch, sftk_searchObjectList would acquire and release the
    SFTKSlot's objectLock once per bucket in the SFTKSlot's sessObjHashTable. This
    patch reduces the locking overhead by acquiring the lock once and then iterating
    over the entire table.
    
    This patch also removes the unused PRBool tokenOnly in NSC_FindObjectsInit (the
    only caller of sftk_searchObjectList). (Changeset b8f289456399 removed the code
    that modified tokenOnly. Unfortunately there doesn't appear to be a bug
    associated with that changeset, so we can't easily determine if that was
    intended. In any case, it's been this way for a decade, so if anything was
    broken by this, no one has noticed yet.)
    
    Reviewers: franziskus
    
    Reviewed By: franziskus
    
    Differential Revision: https://nss-review.dev.mozaws.net/D316
    
    --HG--
    extra : amend_source : b9454fd1fcd5fc587c41e7c39eb81d031730168e
    477cca58
Name
Last commit
Last update
automation Loading commit data...
cmd Loading commit data...
coreconf Loading commit data...
cpputil Loading commit data...
doc Loading commit data...
fuzz Loading commit data...
gtests Loading commit data...
lib Loading commit data...
nss-tool Loading commit data...
pkg Loading commit data...
tests Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.hgignore Loading commit data...
.hgtags Loading commit data...
.taskcluster.yml Loading commit data...
COPYING Loading commit data...
Makefile Loading commit data...
build.sh Loading commit data...
exports.gyp Loading commit data...
help.txt Loading commit data...
manifest.mn Loading commit data...
nss.gyp Loading commit data...
readme.md Loading commit data...
trademarks.txt Loading commit data...