1. 19 Dec, 2018 1 commit
    • Jonas Allmann's avatar
      Bug 1514999 - Add wycheproof Curve25519 testcases to nss, r=franziskus · 69203eee
      Jonas Allmann authored
      Differential Revision: https://phabricator.services.mozilla.com/D14843
      
      --HG--
      rename : gtests/common/chachapoly-vectors.h => gtests/common/testvectors/chachapoly-vectors.h
      rename : gtests/common/gcm-vectors.h => gtests/common/testvectors/gcm-vectors.h
      rename : gtests/common/wycheproof/header_bases/chachapoly-vectors.h => gtests/common/testvectors_base/chachapoly-vectors_base.h
      rename : gtests/common/wycheproof/header_bases/gcm-vectors.h => gtests/common/testvectors_base/gcm-vectors_base.h
      rename : gtests/common/wycheproof/testvectors/aes_gcm_test.json => gtests/common/wycheproof/source_vectors/aes_gcm_test.json
      rename : gtests/common/wycheproof/testvectors/chacha20_poly1305_test.json => gtests/common/wycheproof/source_vectors/chacha20_poly1305_test.json
      extra : amend_source : c6a4e9bc385e669347b13bbe1703eed65e385d6c
      69203eee
  2. 13 Dec, 2018 1 commit
  3. 11 Dec, 2018 1 commit
  4. 30 Nov, 2018 1 commit
  5. 31 Oct, 2018 1 commit
  6. 29 Nov, 2018 1 commit
  7. 22 Nov, 2018 1 commit
  8. 21 Nov, 2018 1 commit
    • Daiki Ueno's avatar
      Bug 1481271, resend the same ticket in ClientHello after HRR, r=mt · 5d49b9e3
      Daiki Ueno authored
      Summary:
      This is an another attempt to fix the issue: store the sent session ticket in `ssl3.hs` until the client receives ServerHello.
      Test is not ready as I couldn't find any easy way to establish multiple connections in gtests to reproduce the scenario described in comment 7.
      
      Reviewers: mt
      
      Reviewed By: mt
      
      Subscribers: franziskus, jcj, mt, ekr, ueno, rrelyea, Alex_Gaynor, mccr8, HubertKario
      
      Tags: #secure-revision, PHID-PROJ-ffhf7tdvqze7zrdn6dh3
      
      Bug #: 1481271
      
      Differential Revision: https://phabricator.services.mozilla.com/D7493
      
      --HG--
      extra : amend_source : e7d34e4b47bc7d495197ef2cdca09876e76676b5
      5d49b9e3
  9. 25 Oct, 2018 1 commit
    • Martin Thomson's avatar
      Bug 1423043 - Enable half-close, r=ttaubert,ekr · cf9543d2
      Martin Thomson authored
      Summary:
      TLS 1.3 explicitly changed to allow close_notify on one half of the
      connection.  Since SSL, an endpoint was required to send close_notify if it
      received close_notify.  The general agreement was that this was a silly
      requirement and that we would remove it and allow one side of the connection to
      be closed.  This is critical for some protocols that are being moved to use
      TLS.
      
      NSS was almost perfect here.  The only problem was that it suppressed the
      second close_notify.  I've added a test for that.
      
      Differential Revision: https://phabricator.services.mozilla.com/D797
      
      --HG--
      extra : source : f3122e5bfb5e5c9d1c6ca4f37fde170d7e289b77
      extra : amend_source : 3debaa587e2aeda7b7c4440b03cb38952ecc8d41
      cf9543d2
  10. 23 Oct, 2018 1 commit
  11. 12 Oct, 2018 3 commits
    • Martin Thomson's avatar
      Bug 1493769 - Set session_id for external resumption tokens, r=franziskus · e533ed60
      Martin Thomson authored
      This also includes some cleanup that I performed when looking into this.
      
      It turns out that the hacks that we were using for managing the reference count
      on sids was unnecessary.  Daiki added a much neater solution in D7493 that I
      stole.
      
      The error handling in SSLExp_SetResumptionToken looks nicer after a
      spring-clean too.
      
      --HG--
      extra : rebase_source : a4aeff32ce0cee61743d98234a21d7726a8dc496
      extra : amend_source : 9b3492f78154ebad6216e9a0dacd7e498d906927
      e533ed60
    • EKR's avatar
      Bug 1498437 - Require that the server negotiate TLS 1.3 if we sent ESNI. r=mt · b2e3f773
      EKR authored
      Reviewers: mt
      
      Tags: #secure-revision
      
      Bug #: 1498437
      
      Differential Revision: https://phabricator.services.mozilla.com/D8496
      b2e3f773
    • Martin Thomson's avatar
      Bug 1489945 - Handle second ticket with external ticket caching, r=franziskus · 74bce7bb
      Martin Thomson authored
      Summary:
      If we get a second session ticket in TLS 1.3 (as boringssl is wont to
      do, and maybe others) while the external session cache is enabled, we assert.
      The fix is to stop assuming that only in_client_cache sessions have a ticket
      attached.  The bigger fix ensures that sessions are properly labelled so that we
      correctly create a new session in the event that we get multiple tickets from a
      server.
      
      I *think* that this isn't that high a priority.  Michal is apparently working on
      code related to this, but should still be able to make progress by disabling TLS
      1.3 (or avoiding boringSSL servers).
      
      Reviewers: franziskus, ekr
      
      Reviewed By: franziskus
      
      Bug #: 1489945
      
      Differential Revision: https://phabricator.services.mozilla.com/D5740
      
      --HG--
      extra : rebase_source : 5203e4275b86605cf71662c2abd4fe58ec8b560c
      extra : amend_source : ad8290b441bee98fb5fe3615c0c96f4fe2e41d6c
      74bce7bb
  12. 03 Aug, 2018 2 commits
    • Franziskus Kiefer's avatar
      Bug 1479787 - clang-format, r=mt,keeler · 944915ea
      Franziskus Kiefer authored
      Differential Revision: https://phabricator.services.mozilla.com/D2721
      
      --HG--
      extra : rebase_source : 8b075cdf10c7864c532017d27785644446f4d33f
      944915ea
    • Franziskus Kiefer's avatar
      Bug 1479787 - build mozpkix as part of NSS, r=mt,keeler · 53850b92
      Franziskus Kiefer authored
      Differential Revision: https://phabricator.services.mozilla.com/D2719
      Differential Revision: https://phabricator.services.mozilla.com/D2720
      Differential Revision: https://phabricator.services.mozilla.com/D2861
      
      --HG--
      rename : cpputil/scoped_ptrs.h => cpputil/nss_scoped_ptrs.h
      rename : lib/mozpkix/test/gtest/README.txt => gtests/mozpkix_gtest/README.txt
      rename : lib/mozpkix/test/gtest/pkixbuild_tests.cpp => gtests/mozpkix_gtest/pkixbuild_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcert_extension_tests.cpp => gtests/mozpkix_gtest/pkixcert_extension_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcert_signature_algorithm_tests.cpp => gtests/mozpkix_gtest/pkixcert_signature_algorithm_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp => gtests/mozpkix_gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_CheckIssuer_tests.cpp => gtests/mozpkix_gtest/pkixcheck_CheckIssuer_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_CheckKeyUsage_tests.cpp => gtests/mozpkix_gtest/pkixcheck_CheckKeyUsage_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp => gtests/mozpkix_gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_CheckValidity_tests.cpp => gtests/mozpkix_gtest/pkixcheck_CheckValidity_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_ParseValidity_tests.cpp => gtests/mozpkix_gtest/pkixcheck_ParseValidity_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixcheck_TLSFeaturesSatisfiedInternal_tests.cpp => gtests/mozpkix_gtest/pkixcheck_TLSFeaturesSatisfiedInternal_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixder_input_tests.cpp => gtests/mozpkix_gtest/pkixder_input_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixder_pki_types_tests.cpp => gtests/mozpkix_gtest/pkixder_pki_types_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixder_universal_types_tests.cpp => gtests/mozpkix_gtest/pkixder_universal_types_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixgtest.cpp => gtests/mozpkix_gtest/pkixgtest.cpp
      rename : lib/mozpkix/test/gtest/pkixgtest.h => gtests/mozpkix_gtest/pkixgtest.h
      rename : lib/mozpkix/test/gtest/pkixnames_tests.cpp => gtests/mozpkix_gtest/pkixnames_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp => gtests/mozpkix_gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp
      rename : lib/mozpkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp => gtests/mozpkix_gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp
      rename : lib/mozpkix/test/lib/pkixtestnss.h => lib/mozpkix/include/pkix-test/pkixtestnss.h
      rename : lib/mozpkix/test/lib/pkixtestutil.h => lib/mozpkix/include/pkix-test/pkixtestutil.h
      rename : lib/mozpkix/lib/pkixcheck.h => lib/mozpkix/include/pkix/pkixcheck.h
      rename : lib/mozpkix/lib/pkixder.h => lib/mozpkix/include/pkix/pkixder.h
      rename : lib/mozpkix/lib/pkixutil.h => lib/mozpkix/include/pkix/pkixutil.h
      rename : lib/mozpkix/test/lib/pkixtestalg.cpp => lib/mozpkix/test-lib/pkixtestalg.cpp
      rename : lib/mozpkix/test/lib/pkixtestnss.cpp => lib/mozpkix/test-lib/pkixtestnss.cpp
      rename : lib/mozpkix/test/lib/pkixtestutil.cpp => lib/mozpkix/test-lib/pkixtestutil.cpp
      extra : rebase_source : 7b1375fef0c8e0c361f44d16f69c31d0bd6d0b41
      53850b92
  13. 28 Sep, 2018 1 commit
  14. 23 Sep, 2018 1 commit
  15. 08 May, 2018 1 commit
    • Martin Thomson's avatar
      Bug 1459824 - Enable 0.5 RTT data from the server, r=ekr · 6f6c06fc
      Martin Thomson authored
      This uses the recently added tls13_CanRequestClientAuth() function to determine
      whether the server is able to request a certificate.  If it can, then we disable
      0.5 RTT.  Note that there are two ways to enable 0.5 RTT as a result:
      
      1. Don't request a client certificate
      2. This is a resumption handshake
      
      The latter is non-obvious, so I've added a big comment.
      
      --HG--
      extra : rebase_source : f96eacbfb70f1e6cb1d1e8c8539d166164743410
      extra : amend_source : b7a13f05cb1a3968e0895b38cc7bdc07ecf92ef6
      6f6c06fc
  16. 22 Sep, 2018 1 commit
    • Dipen Patel's avatar
      Bug 1489691 - CTR_Update_HW_AES assert failure r=mt · ffb975ea
      Dipen Patel authored
      Summary:
      The assert for outlen == 0 was being hit when multiple cipher updates
      that were not block aligned were invoked for a single context.
      
      The assumption that intel_aes_ctr_worker() set outlen to zero was incorrect. It
      only sets the return result to 0.
      
      Reviewers: mt
      
      Reviewed By: mt
      
      Subscribers: rhelmer
      
      Bug #: 1489691
      
      Differential Revision: https://phabricator.services.mozilla.com/D5984
      
      --HG--
      extra : amend_source : b533d0fa3ce06b93b73241f97144011cf0b1b86c
      ffb975ea
  17. 04 Sep, 2018 1 commit
  18. 29 Aug, 2018 1 commit
    • Martin Thomson's avatar
      Bug 1486987 - Update googletest, r=ueno · de59c127
      Martin Thomson authored
      This adds a new script for updating gtest so that updating is easier.
      
      It updates googletest to release-1.8.1.
      
      --HG--
      rename : gtests/google_test/gtest/README => gtests/google_test/gtest/README.md
      rename : gtests/google_test/gtest/msvc/gtest-md.sln => gtests/google_test/gtest/msvc/2010/gtest-md.sln
      rename : gtests/google_test/gtest/msvc/gtest-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest.sln => gtests/google_test/gtest/msvc/2010/gtest.sln
      rename : gtests/google_test/gtest/msvc/gtest.vcproj => gtests/google_test/gtest/msvc/2010/gtest.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_main-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_main-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_main.vcproj => gtests/google_test/gtest/msvc/2010/gtest_main.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_prod_test-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_prod_test-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_prod_test.vcproj => gtests/google_test/gtest/msvc/2010/gtest_prod_test.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_unittest-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_unittest-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_unittest.vcproj => gtests/google_test/gtest/msvc/2010/gtest_unittest.vcxproj
      rename : gtests/google_test/gtest/test/gtest_break_on_failure_unittest.py => gtests/google_test/gtest/test/googletest-break-on-failure-unittest.py
      rename : gtests/google_test/gtest/test/gtest_break_on_failure_unittest_.cc => gtests/google_test/gtest/test/googletest-break-on-failure-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest_catch_exceptions_test.py => gtests/google_test/gtest/test/googletest-catch-exceptions-test.py
      rename : gtests/google_test/gtest/test/gtest_catch_exceptions_test_.cc => gtests/google_test/gtest/test/googletest-catch-exceptions-test_.cc
      rename : gtests/google_test/gtest/test/gtest_color_test.py => gtests/google_test/gtest/test/googletest-color-test.py
      rename : gtests/google_test/gtest/test/gtest_color_test_.cc => gtests/google_test/gtest/test/googletest-color-test_.cc
      rename : gtests/google_test/gtest/test/gtest-death-test_test.cc => gtests/google_test/gtest/test/googletest-death-test-test.cc
      rename : gtests/google_test/gtest/test/gtest-death-test_ex_test.cc => gtests/google_test/gtest/test/googletest-death-test_ex_test.cc
      rename : gtests/google_test/gtest/test/gtest_env_var_test.py => gtests/google_test/gtest/test/googletest-env-var-test.py
      rename : gtests/google_test/gtest/test/gtest_env_var_test_.cc => gtests/google_test/gtest/test/googletest-env-var-test_.cc
      rename : gtests/google_test/gtest/test/gtest-filepath_test.cc => gtests/google_test/gtest/test/googletest-filepath-test.cc
      rename : gtests/google_test/gtest/test/gtest_filter_unittest.py => gtests/google_test/gtest/test/googletest-filter-unittest.py
      rename : gtests/google_test/gtest/test/gtest_filter_unittest_.cc => gtests/google_test/gtest/test/googletest-filter-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest-linked_ptr_test.cc => gtests/google_test/gtest/test/googletest-linked-ptr-test.cc
      rename : gtests/google_test/gtest/test/gtest_list_tests_unittest.py => gtests/google_test/gtest/test/googletest-list-tests-unittest.py
      rename : gtests/google_test/gtest/test/gtest_list_tests_unittest_.cc => gtests/google_test/gtest/test/googletest-list-tests-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest-listener_test.cc => gtests/google_test/gtest/test/googletest-listener-test.cc
      rename : gtests/google_test/gtest/test/gtest-message_test.cc => gtests/google_test/gtest/test/googletest-message-test.cc
      rename : gtests/google_test/gtest/test/gtest-options_test.cc => gtests/google_test/gtest/test/googletest-options-test.cc
      rename : gtests/google_test/gtest/test/gtest_output_test_golden_lin.txt => gtests/google_test/gtest/test/googletest-output-test-golden-lin.txt
      rename : gtests/google_test/gtest/test/gtest_output_test.py => gtests/google_test/gtest/test/googletest-output-test.py
      rename : gtests/google_test/gtest/test/gtest_output_test_.cc => gtests/google_test/gtest/test/googletest-output-test_.cc
      rename : gtests/google_test/gtest/test/gtest-param-test_test.cc => gtests/google_test/gtest/test/googletest-param-test-test.cc
      rename : gtests/google_test/gtest/test/gtest-param-test_test.h => gtests/google_test/gtest/test/googletest-param-test-test.h
      rename : gtests/google_test/gtest/test/gtest-param-test2_test.cc => gtests/google_test/gtest/test/googletest-param-test2-test.cc
      rename : gtests/google_test/gtest/test/gtest-port_test.cc => gtests/google_test/gtest/test/googletest-port-test.cc
      rename : gtests/google_test/gtest/test/gtest-printers_test.cc => gtests/google_test/gtest/test/googletest-printers-test.cc
      rename : gtests/google_test/gtest/test/gtest_shuffle_test.py => gtests/google_test/gtest/test/googletest-shuffle-test.py
      rename : gtests/google_test/gtest/test/gtest_shuffle_test_.cc => gtests/google_test/gtest/test/googletest-shuffle-test_.cc
      rename : gtests/google_test/gtest/test/gtest-test-part_test.cc => gtests/google_test/gtest/test/googletest-test-part-test.cc
      rename : gtests/google_test/gtest/test/gtest_throw_on_failure_test.py => gtests/google_test/gtest/test/googletest-throw-on-failure-test.py
      rename : gtests/google_test/gtest/test/gtest_throw_on_failure_test_.cc => gtests/google_test/gtest/test/googletest-throw-on-failure-test_.cc
      rename : gtests/google_test/gtest/test/gtest-tuple_test.cc => gtests/google_test/gtest/test/googletest-tuple-test.cc
      rename : gtests/google_test/gtest/test/gtest_uninitialized_test.py => gtests/google_test/gtest/test/googletest-uninitialized-test.py
      rename : gtests/google_test/gtest/test/gtest_uninitialized_test_.cc => gtests/google_test/gtest/test/googletest-uninitialized-test_.cc
      extra : rebase_source : c55c64e844bee766d92501e99721d59c1e2df487
      extra : amend_source : 7b5fcad864414dc6cf035bce3d3fff2254e32d54
      de59c127
  19. 28 Aug, 2018 1 commit
    • Martin Thomson's avatar
      Bug 1483128 - Test that randoms aren't fixed, r=ekr · 9c9f8340
      Martin Thomson authored
      We can't easily test that ClientHello.random and ServerHello.random are truly
      random in these tests, but we can catch mistakes the likes of which produced
      this bug.  This just runs a few handshakes and tests that none of the random
      values are equal to any other, or they are equal to zero.
      
      --HG--
      extra : rebase_source : 31c0ad2addc22b9ae2dbdfecabf2aed2ba6b76b5
      extra : amend_source : 61069932be7f248758bb9b1f857561ddfacbd555
      9c9f8340
  20. 03 Sep, 2018 1 commit
  21. 31 Aug, 2018 3 commits
  22. 01 May, 2018 1 commit
  23. 29 Aug, 2018 2 commits
    • Martin Thomson's avatar
      Backed out changeset d89917892e22::d89917892e22 · 0e1ab41d
      Martin Thomson authored
      --HG--
      rename : gtests/google_test/gtest/README.md => gtests/google_test/gtest/README
      rename : gtests/google_test/gtest/msvc/2010/gtest-md.sln => gtests/google_test/gtest/msvc/gtest-md.sln
      rename : gtests/google_test/gtest/msvc/2010/gtest-md.vcxproj => gtests/google_test/gtest/msvc/gtest-md.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest.sln => gtests/google_test/gtest/msvc/gtest.sln
      rename : gtests/google_test/gtest/msvc/2010/gtest.vcxproj => gtests/google_test/gtest/msvc/gtest.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_main-md.vcxproj => gtests/google_test/gtest/msvc/gtest_main-md.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_main.vcxproj => gtests/google_test/gtest/msvc/gtest_main.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_prod_test-md.vcxproj => gtests/google_test/gtest/msvc/gtest_prod_test-md.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_prod_test.vcxproj => gtests/google_test/gtest/msvc/gtest_prod_test.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_unittest-md.vcxproj => gtests/google_test/gtest/msvc/gtest_unittest-md.vcproj
      rename : gtests/google_test/gtest/msvc/2010/gtest_unittest.vcxproj => gtests/google_test/gtest/msvc/gtest_unittest.vcproj
      rename : gtests/google_test/gtest/test/googletest-death-test_ex_test.cc => gtests/google_test/gtest/test/gtest-death-test_ex_test.cc
      rename : gtests/google_test/gtest/test/googletest-death-test-test.cc => gtests/google_test/gtest/test/gtest-death-test_test.cc
      rename : gtests/google_test/gtest/test/googletest-filepath-test.cc => gtests/google_test/gtest/test/gtest-filepath_test.cc
      rename : gtests/google_test/gtest/test/googletest-linked-ptr-test.cc => gtests/google_test/gtest/test/gtest-linked_ptr_test.cc
      rename : gtests/google_test/gtest/test/googletest-listener-test.cc => gtests/google_test/gtest/test/gtest-listener_test.cc
      rename : gtests/google_test/gtest/test/googletest-message-test.cc => gtests/google_test/gtest/test/gtest-message_test.cc
      rename : gtests/google_test/gtest/test/googletest-options-test.cc => gtests/google_test/gtest/test/gtest-options_test.cc
      rename : gtests/google_test/gtest/test/googletest-param-test2-test.cc => gtests/google_test/gtest/test/gtest-param-test2_test.cc
      rename : gtests/google_test/gtest/test/googletest-param-test-test.cc => gtests/google_test/gtest/test/gtest-param-test_test.cc
      rename : gtests/google_test/gtest/test/googletest-param-test-test.h => gtests/google_test/gtest/test/gtest-param-test_test.h
      rename : gtests/google_test/gtest/test/googletest-port-test.cc => gtests/google_test/gtest/test/gtest-port_test.cc
      rename : gtests/google_test/gtest/test/googletest-printers-test.cc => gtests/google_test/gtest/test/gtest-printers_test.cc
      rename : gtests/google_test/gtest/test/googletest-test-part-test.cc => gtests/google_test/gtest/test/gtest-test-part_test.cc
      rename : gtests/google_test/gtest/test/googletest-tuple-test.cc => gtests/google_test/gtest/test/gtest-tuple_test.cc
      rename : gtests/google_test/gtest/test/googletest-break-on-failure-unittest.py => gtests/google_test/gtest/test/gtest_break_on_failure_unittest.py
      rename : gtests/google_test/gtest/test/googletest-break-on-failure-unittest_.cc => gtests/google_test/gtest/test/gtest_break_on_failure_unittest_.cc
      rename : gtests/google_test/gtest/test/googletest-catch-exceptions-test.py => gtests/google_test/gtest/test/gtest_catch_exceptions_test.py
      rename : gtests/google_test/gtest/test/googletest-catch-exceptions-test_.cc => gtests/google_test/gtest/test/gtest_catch_exceptions_test_.cc
      rename : gtests/google_test/gtest/test/googletest-color-test.py => gtests/google_test/gtest/test/gtest_color_test.py
      rename : gtests/google_test/gtest/test/googletest-color-test_.cc => gtests/google_test/gtest/test/gtest_color_test_.cc
      rename : gtests/google_test/gtest/test/googletest-env-var-test.py => gtests/google_test/gtest/test/gtest_env_var_test.py
      rename : gtests/google_test/gtest/test/googletest-env-var-test_.cc => gtests/google_test/gtest/test/gtest_env_var_test_.cc
      rename : gtests/google_test/gtest/test/googletest-filter-unittest.py => gtests/google_test/gtest/test/gtest_filter_unittest.py
      rename : gtests/google_test/gtest/test/googletest-filter-unittest_.cc => gtests/google_test/gtest/test/gtest_filter_unittest_.cc
      rename : gtests/google_test/gtest/test/googletest-list-tests-unittest.py => gtests/google_test/gtest/test/gtest_list_tests_unittest.py
      rename : gtests/google_test/gtest/test/googletest-list-tests-unittest_.cc => gtests/google_test/gtest/test/gtest_list_tests_unittest_.cc
      rename : gtests/google_test/gtest/test/googletest-output-test.py => gtests/google_test/gtest/test/gtest_output_test.py
      rename : gtests/google_test/gtest/test/googletest-output-test_.cc => gtests/google_test/gtest/test/gtest_output_test_.cc
      rename : gtests/google_test/gtest/test/googletest-output-test-golden-lin.txt => gtests/google_test/gtest/test/gtest_output_test_golden_lin.txt
      rename : gtests/google_test/gtest/test/googletest-shuffle-test.py => gtests/google_test/gtest/test/gtest_shuffle_test.py
      rename : gtests/google_test/gtest/test/googletest-shuffle-test_.cc => gtests/google_test/gtest/test/gtest_shuffle_test_.cc
      rename : gtests/google_test/gtest/test/googletest-throw-on-failure-test.py => gtests/google_test/gtest/test/gtest_throw_on_failure_test.py
      rename : gtests/google_test/gtest/test/googletest-throw-on-failure-test_.cc => gtests/google_test/gtest/test/gtest_throw_on_failure_test_.cc
      rename : gtests/google_test/gtest/test/googletest-uninitialized-test.py => gtests/google_test/gtest/test/gtest_uninitialized_test.py
      rename : gtests/google_test/gtest/test/googletest-uninitialized-test_.cc => gtests/google_test/gtest/test/gtest_uninitialized_test_.cc
      extra : amend_source : 0a7b65657d37b2921a992ef71c90d724eab60d16
      0e1ab41d
    • Martin Thomson's avatar
      Bug 1486987 - Update googletest, r?kaie · 393d183f
      Martin Thomson authored
      --HG--
      rename : gtests/google_test/gtest/README => gtests/google_test/gtest/README.md
      rename : gtests/google_test/gtest/msvc/gtest-md.sln => gtests/google_test/gtest/msvc/2010/gtest-md.sln
      rename : gtests/google_test/gtest/msvc/gtest-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest.sln => gtests/google_test/gtest/msvc/2010/gtest.sln
      rename : gtests/google_test/gtest/msvc/gtest.vcproj => gtests/google_test/gtest/msvc/2010/gtest.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_main-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_main-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_main.vcproj => gtests/google_test/gtest/msvc/2010/gtest_main.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_prod_test-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_prod_test-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_prod_test.vcproj => gtests/google_test/gtest/msvc/2010/gtest_prod_test.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_unittest-md.vcproj => gtests/google_test/gtest/msvc/2010/gtest_unittest-md.vcxproj
      rename : gtests/google_test/gtest/msvc/gtest_unittest.vcproj => gtests/google_test/gtest/msvc/2010/gtest_unittest.vcxproj
      rename : gtests/google_test/gtest/test/gtest_break_on_failure_unittest.py => gtests/google_test/gtest/test/googletest-break-on-failure-unittest.py
      rename : gtests/google_test/gtest/test/gtest_break_on_failure_unittest_.cc => gtests/google_test/gtest/test/googletest-break-on-failure-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest_catch_exceptions_test.py => gtests/google_test/gtest/test/googletest-catch-exceptions-test.py
      rename : gtests/google_test/gtest/test/gtest_catch_exceptions_test_.cc => gtests/google_test/gtest/test/googletest-catch-exceptions-test_.cc
      rename : gtests/google_test/gtest/test/gtest_color_test.py => gtests/google_test/gtest/test/googletest-color-test.py
      rename : gtests/google_test/gtest/test/gtest_color_test_.cc => gtests/google_test/gtest/test/googletest-color-test_.cc
      rename : gtests/google_test/gtest/test/gtest-death-test_test.cc => gtests/google_test/gtest/test/googletest-death-test-test.cc
      rename : gtests/google_test/gtest/test/gtest-death-test_ex_test.cc => gtests/google_test/gtest/test/googletest-death-test_ex_test.cc
      rename : gtests/google_test/gtest/test/gtest_env_var_test.py => gtests/google_test/gtest/test/googletest-env-var-test.py
      rename : gtests/google_test/gtest/test/gtest_env_var_test_.cc => gtests/google_test/gtest/test/googletest-env-var-test_.cc
      rename : gtests/google_test/gtest/test/gtest-filepath_test.cc => gtests/google_test/gtest/test/googletest-filepath-test.cc
      rename : gtests/google_test/gtest/test/gtest_filter_unittest.py => gtests/google_test/gtest/test/googletest-filter-unittest.py
      rename : gtests/google_test/gtest/test/gtest_filter_unittest_.cc => gtests/google_test/gtest/test/googletest-filter-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest-linked_ptr_test.cc => gtests/google_test/gtest/test/googletest-linked-ptr-test.cc
      rename : gtests/google_test/gtest/test/gtest_list_tests_unittest.py => gtests/google_test/gtest/test/googletest-list-tests-unittest.py
      rename : gtests/google_test/gtest/test/gtest_list_tests_unittest_.cc => gtests/google_test/gtest/test/googletest-list-tests-unittest_.cc
      rename : gtests/google_test/gtest/test/gtest-listener_test.cc => gtests/google_test/gtest/test/googletest-listener-test.cc
      rename : gtests/google_test/gtest/test/gtest-message_test.cc => gtests/google_test/gtest/test/googletest-message-test.cc
      rename : gtests/google_test/gtest/test/gtest-options_test.cc => gtests/google_test/gtest/test/googletest-options-test.cc
      rename : gtests/google_test/gtest/test/gtest_output_test_golden_lin.txt => gtests/google_test/gtest/test/googletest-output-test-golden-lin.txt
      rename : gtests/google_test/gtest/test/gtest_output_test.py => gtests/google_test/gtest/test/googletest-output-test.py
      rename : gtests/google_test/gtest/test/gtest_output_test_.cc => gtests/google_test/gtest/test/googletest-output-test_.cc
      rename : gtests/google_test/gtest/test/gtest-param-test_test.cc => gtests/google_test/gtest/test/googletest-param-test-test.cc
      rename : gtests/google_test/gtest/test/gtest-param-test_test.h => gtests/google_test/gtest/test/googletest-param-test-test.h
      rename : gtests/google_test/gtest/test/gtest-param-test2_test.cc => gtests/google_test/gtest/test/googletest-param-test2-test.cc
      rename : gtests/google_test/gtest/test/gtest-port_test.cc => gtests/google_test/gtest/test/googletest-port-test.cc
      rename : gtests/google_test/gtest/test/gtest-printers_test.cc => gtests/google_test/gtest/test/googletest-printers-test.cc
      rename : gtests/google_test/gtest/test/gtest_shuffle_test.py => gtests/google_test/gtest/test/googletest-shuffle-test.py
      rename : gtests/google_test/gtest/test/gtest_shuffle_test_.cc => gtests/google_test/gtest/test/googletest-shuffle-test_.cc
      rename : gtests/google_test/gtest/test/gtest-test-part_test.cc => gtests/google_test/gtest/test/googletest-test-part-test.cc
      rename : gtests/google_test/gtest/test/gtest_throw_on_failure_test.py => gtests/google_test/gtest/test/googletest-throw-on-failure-test.py
      rename : gtests/google_test/gtest/test/gtest_throw_on_failure_test_.cc => gtests/google_test/gtest/test/googletest-throw-on-failure-test_.cc
      rename : gtests/google_test/gtest/test/gtest-tuple_test.cc => gtests/google_test/gtest/test/googletest-tuple-test.cc
      rename : gtests/google_test/gtest/test/gtest_uninitialized_test.py => gtests/google_test/gtest/test/googletest-uninitialized-test.py
      rename : gtests/google_test/gtest/test/gtest_uninitialized_test_.cc => gtests/google_test/gtest/test/googletest-uninitialized-test_.cc
      393d183f
  24. 27 Aug, 2018 1 commit
  25. 17 Aug, 2018 1 commit
  26. 15 Aug, 2018 1 commit
  27. 09 Jul, 2018 1 commit
    • Martin Thomson's avatar
      Bug 1483129 - TLS 1.3 RFC version, r=ekr · f182940c
      Martin Thomson authored
      This retains the ability to negotiate draft versions of DTLS 1.3, but uses the
      final RFC version for TLS 1.3.
      
      This also refactors the handling of the downgrade sentinel.  As we've discovered
      - to our dismay - some MitM boxes forward handshake messages when they
      shouldn't.  This could result in triggering the downgrade sentinel.  I've done
      two things here:
      
      - The server always sets the sentinel.  It reduces the assumed version if it
        only supports a draft version though on the basis that the client might
        expect the full version.
      
      - The client has a new option SSL_ENABLE_HELLO_DOWNGRADE_CHECK which is disabled
        by default.  The client will reject a handshake that appears to be a downgrade
        only when this is explicitly enabled.  The client will allow an apparent
        downgrade to TLS 1.2 if it is running a draft version of TLS 1.3.
      
      The allowance for a draft version is now only effective for DTLS 1.3.
      
      Tests for version downgrade have been updated and enabled.  These were rotten in
      a few ways, but nothing dramatic.
      
      --HG--
      extra : rebase_source : 3c878c212fffbaa3cb6881f3f705ed5e6c25d42c
      f182940c
  28. 22 Aug, 2018 1 commit
    • Daiki Ueno's avatar
      Bug 1471967, skip unrecognized session tickets in TLS 1.3, r=ekr · 0c3fab7e
      Daiki Ueno authored
      Summary: In TLS 1.3, upon receiving a malformed ticket, server doesn't immediately abort the connection, but rejects client's resumption attempt.
      
      Reviewers: ekr
      
      Reviewed By: ekr
      
      Subscribers: mt, ekr, kaie, ueno, rrelyea, HubertKario
      
      Tags: #secure-revision, PHID-PROJ-ffhf7tdvqze7zrdn6dh3
      
      Bug #: 1471967
      
      Differential Revision: https://phabricator.services.mozilla.com/D3620
      
      --HG--
      extra : rebase_source : 8d81c1c91d58f363f29ef1e5084cfcdf142f3d38
      extra : amend_source : 518ae54337eafe0fa5054637cc9b8a2aea5c8282
      0c3fab7e
  29. 21 Aug, 2018 1 commit
  30. 15 Aug, 2018 1 commit
  31. 16 Aug, 2018 1 commit
  32. 15 Aug, 2018 1 commit
    • Daiki Ueno's avatar
      Bug 1414931, send correct alert on inconsistent signature scheme, r=mt · 361b72f4
      Daiki Ueno authored
      Summary:
      This fixes the corner cases where incorrect alert is sent (or even no
      alert is sent):
      - when the client's CertificateVerify is signed with rsa_pss_pss_*,
        while the certificate is RSA
      - when the client's CertificateVerify is signed with rsa_pss_rsae_*,
        while the certificate is RSA-PSS
      - when ServerKeyExchange is signed with an inconsistent signature
        scheme with the server certificate
      
      Reviewers: mt
      
      Reviewed By: mt
      
      Bug #: 1414931
      
      Differential Revision: https://phabricator.services.mozilla.com/D3321
      
      --HG--
      extra : rebase_source : a2f612403d0b4320c1976bb88fafb2927fcf0d0a
      extra : amend_source : dc2123081473460a234d76f6d89bd8903462f23c
      361b72f4
  33. 07 Aug, 2018 1 commit
  34. 10 Aug, 2018 1 commit
    • Daiki Ueno's avatar
      Bug 1481873, correct signature_algorithms extension handling, r=mt · 041ad25d
      Daiki Ueno authored
      Summary:
      This fixes a couple of issues in signature_algorithms extension handling:
      - MAX_SIGNATURE_SCHEMES is out of sync with ssl_IsSupportedSignatureScheme()
      - when the extension consists of many bogus/duplicate entries followed by a valid signature scheme, ssl_ParseSignatureSchemes() gives up too early
      
      Reviewers: mt
      
      Reviewed By: mt
      
      Subscribers: HubertKario
      
      Bug #: 1481873
      
      Differential Revision: https://phabricator.services.mozilla.com/D3014
      
      --HG--
      extra : rebase_source : 290785ee8ad48a7d0e7fa8f935b166406a9b88f9
      extra : amend_source : d72c76890901e4d22f6f02ed3f3e87874986b39c
      041ad25d