diff --git a/build.sh b/build.sh index 4c6d513cd4..6d070af205 100755 --- a/build.sh +++ b/build.sh @@ -50,6 +50,7 @@ fuzz=0 fuzz_tls=0 fuzz_oss=0 no_local_nspr=0 +sslkeylogfile=1 gyp_params=(--depth="$cwd" --generator-output=".") ninja_params=() @@ -103,6 +104,7 @@ while [ $# -gt 0 ]; do --enable-fips) gyp_params+=(-Ddisable_fips=0) ;; --enable-libpkix) gyp_params+=(-Ddisable_libpkix=0) ;; --mozpkix-only) gyp_params+=(-Dmozpkix_only=1 -Ddisable_tests=1 -Dsign_libs=0) ;; + --disable-keylog) sslkeylogfile=0 ;; *) show_help; exit 2 ;; esac shift @@ -116,6 +118,8 @@ else target=Debug fi +gyp_params+=(-Denable_sslkeylogfile="$sslkeylogfile") + # Do special setup. if [ "$fuzz" = 1 ]; then source "$cwd"/coreconf/fuzz.sh diff --git a/gtests/ssl_gtest/ssl_gtest.gyp b/gtests/ssl_gtest/ssl_gtest.gyp index ae7d4c78b1..8a7070a736 100644 --- a/gtests/ssl_gtest/ssl_gtest.gyp +++ b/gtests/ssl_gtest/ssl_gtest.gyp @@ -33,7 +33,6 @@ 'ssl_gather_unittest.cc', 'ssl_gtest.cc', 'ssl_hrr_unittest.cc', - 'ssl_keylog_unittest.cc', 'ssl_keyupdate_unittest.cc', 'ssl_loopback_unittest.cc', 'ssl_misc_unittest.cc', @@ -92,6 +91,14 @@ '<(DEPTH)/lib/dbm/src/src.gyp:dbm', ], }], + [ 'enable_sslkeylogfile==1', { + 'sources': [ + 'ssl_keylog_unittest.cc', + ], + 'defines': [ + 'NSS_ALLOW_SSLKEYLOGFILE', + ], + }], ], } ], @@ -101,7 +108,6 @@ ], 'defines': [ 'NSS_USE_STATIC_LIBS', - 'NSS_ALLOW_SSLKEYLOGFILE=1', ], }, 'variables': { diff --git a/gtests/ssl_gtest/ssl_keylog_unittest.cc b/gtests/ssl_gtest/ssl_keylog_unittest.cc index d616dd2503..4713e52a2b 100644 --- a/gtests/ssl_gtest/ssl_keylog_unittest.cc +++ b/gtests/ssl_gtest/ssl_keylog_unittest.cc @@ -4,8 +4,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this file, * You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifdef NSS_ALLOW_SSLKEYLOGFILE - #include #include #include @@ -164,5 +162,3 @@ INSTANTIATE_TEST_CASE_P( #endif } // namespace nss_test - -#endif // NSS_ALLOW_SSLKEYLOGFILE diff --git a/help.txt b/help.txt index 1df72736e0..d905f6ec4c 100644 --- a/help.txt +++ b/help.txt @@ -51,3 +51,5 @@ NSS build tool options: --enable-libpkix make libpkix part of the build --mozpkix-only build only static mozpkix and mozpkix-test libraries support for this build option is limited + --disable-keylog enable support for logging key data to a file specified + by the SSLKEYLOGFILE environment variable diff --git a/lib/ssl/ssl.gyp b/lib/ssl/ssl.gyp index 2e28f67757..e456885e49 100644 --- a/lib/ssl/ssl.gyp +++ b/lib/ssl/ssl.gyp @@ -73,6 +73,11 @@ '-std=gnu99', ], }], + [ 'enable_sslkeylogfile==1', { + 'defines': [ + 'NSS_ALLOW_SSLKEYLOGFILE', + ], + }], ], 'dependencies': [ '<(DEPTH)/exports.gyp:nss_exports', @@ -92,11 +97,6 @@ } } ], - 'target_defaults': { - 'defines': [ - 'NSS_ALLOW_SSLKEYLOGFILE=1' - ] - }, 'variables': { 'module': 'nss' }