additional fix for the patch from bug 126087. Must not set symKey->sl…

…ot to NULL after leaving the freelist lock, or somebody else might pick up the symKey from the freelist, have their slot NULL'ed, and whamo..
sailfishos-mirror · Apr 11, 2002 · b94b26f · b94b26f
1 parent ae7fa7d
commit b94b26f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/security/nss/lib/pk11wrap/pk11skey.c b/security/nss/lib/pk11wrap/pk11skey.c
@@ -268,9 +268,9 @@ PK11_FreeSymKey(PK11SymKey *symKey)
             PK11_USE_THREADS(PZ_Lock(slot->freeListLock);)
 	    symKey->next = slot->freeSymKeysHead;
 	    slot->freeSymKeysHead = symKey;
+	    symKey->slot = NULL;
 	    PK11_USE_THREADS(PZ_Unlock(slot->freeListLock);)
 	    PR_AtomicIncrement(&slot->keyCount);
-	    symKey->slot = NULL;
 	    freeit = PR_FALSE;
         }
         if (freeit) {