Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Bug 1540652 - softoken/sdb.c: Logically dead code, r=keeler
Test Plan: https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=b7bd9acb3ca38a1db10c35c295b9bfcae44a5074

Reviewers: keeler

Reviewed By: keeler

Subscribers: mt

Bug #: 1540652

Differential Revision: https://phabricator.services.mozilla.com/D27191

--HG--
extra : rebase_source : c72a1034449add462856d5ab19140059560b631f
  • Loading branch information
Kevin Jacobs committed May 3, 2019
1 parent c8a614f commit b48f008
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lib/softoken/sdb.c
Expand Up @@ -899,10 +899,8 @@ sdb_GetAttributeValueNoLock(SDB *sdb, CK_OBJECT_HANDLE object_id,
}
columns = newColumns;
}
if (!columns) {
error = CKR_OBJECT_HANDLE_INVALID;
goto loser;
}

PORT_Assert(columns);

char *statement = sqlite3_mprintf("SELECT DISTINCT %s FROM %s where id=$ID LIMIT 1;",
columns, table);
Expand Down

0 comments on commit b48f008

Please sign in to comment.