Skip to content

Commit

Permalink
Bug 1661378 - pkix: Do not use NULL where 0 is needed
Browse files Browse the repository at this point in the history
Clang finds this error

pkix_logger.c:316:32: error: cast to smaller integer type 'PKIX_ERRORCLASS' from 'void *' [-Werror,-Wvoid-pointer-to-enum-cast]
        logger->logComponent = (PKIX_ERRORCLASS)NULL;
                               ^~~~~~~~~~~~~~~~~~~~~
pkix_logger.c:617:32: error: cast to smaller integer type 'PKIX_ERRORCLASS' from 'void *' [-Werror,-Wvoid-pointer-to-enum-cast]
        logger->logComponent = (PKIX_ERRORCLASS)NULL;
                               ^~~~~~~~~~~~~~~~~~~~~
2 errors generated.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
  • Loading branch information
kraj committed Sep 2, 2020
1 parent 12c08ef commit b2ad4a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/libpkix/pkix/util/pkix_logger.c
Expand Up @@ -313,7 +313,7 @@ pkix_Logger_Destroy(

logger->callback = NULL;
PKIX_DECREF(logger->context);
logger->logComponent = (PKIX_ERRORCLASS)NULL;
logger->logComponent = (PKIX_ERRORCLASS)0;

cleanup:

Expand Down Expand Up @@ -614,7 +614,7 @@ PKIX_Logger_Create(

logger->callback = callback;
logger->maxLevel = 0;
logger->logComponent = (PKIX_ERRORCLASS)NULL;
logger->logComponent = (PKIX_ERRORCLASS)0;

PKIX_INCREF(loggerContext);
logger->context = loggerContext;
Expand Down

0 comments on commit b2ad4a0

Please sign in to comment.