Bug 1314604 - Extra checking when validating DH shares, r=rrelyea

sailfishos-mirror · Nov 8, 2016 · a218035 · a218035
1 parent 8419a5d
commit a218035
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/ssl/sslsock.c b/lib/ssl/sslsock.c
@@ -1668,6 +1668,9 @@ ssl_IsValidDHEShare(const SECItem *dh_p, const SECItem *dh_Ys)
     unsigned int commonPart;
     int cmp;
 
+    if (dh_p->len == 0 || dh_Ys->len == 0) {
+        return PR_FALSE;
+    }
     /* Check that the prime is at least odd. */
     if ((dh_p->data[dh_p->len - 1] & 0x01) == 0) {
         return PR_FALSE;