Skip to content

Commit

Permalink
Bug 1189020 - Replace |// unnamed namespace| with |// namespace| in m…
Browse files Browse the repository at this point in the history
…ozilla::pkix. r=Cykesiopka

This is what Google suggests in its style guide, and somebody
already changed one of these comments to the new style.

--HG--
extra : rebase_source : fe3f7fc17a2fc09ad0ba01fa1511dc8dba7653e1
  • Loading branch information
briansmith committed Mar 16, 2016
1 parent 529fb34 commit 96ae640
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion lib/mozpkix/lib/pkixder.cpp
Expand Up @@ -104,7 +104,7 @@ AlgorithmIdentifierValue(Reader& input, /*out*/ Reader& algorithmOIDValue)
return OptionalNull(input);
}

} // unnamed namespace
} // namespace

Result
SignatureAlgorithmIdentifierValue(Reader& input,
Expand Down
8 changes: 4 additions & 4 deletions lib/mozpkix/lib/pkixnames.cpp
Expand Up @@ -195,7 +195,7 @@ Result MatchPresentedRFC822NameWithReferenceRFC822Name(
Input presentedRFC822Name, IDRole referenceRFC822NameRole,
Input referenceRFC822Name, /*out*/ bool& matches);

} // unnamed namespace
} // namespace

bool IsValidReferenceDNSID(Input hostname);
bool IsValidPresentedDNSID(Input hostname);
Expand Down Expand Up @@ -1650,7 +1650,7 @@ ReadIPv4AddressComponent(Reader& input, bool lastComponent,
return true;
}

} // unnamed namespace
} // namespace

// On Windows and maybe other platforms, OS-provided IP address parsing
// functions might fail if the protocol (IPv4 or IPv6) has been disabled, so we
Expand Down Expand Up @@ -1706,7 +1706,7 @@ FinishIPv6Address(/*in/out*/ uint8_t (&address)[16], int numComponents,
return true;
}

} // unnamed namespace
} // namespace

// On Windows and maybe other platforms, OS-provided IP address parsing
// functions might fail if the protocol (IPv4 or IPv6) has been disabled, so we
Expand Down Expand Up @@ -2034,6 +2034,6 @@ IsValidDNSID(Input hostname, IDRole idRole, AllowWildcards allowWildcards)
return true;
}

} // unnamed namespace
} // namespace

} } // namespace mozilla::pkix
2 changes: 1 addition & 1 deletion lib/mozpkix/lib/pkixnss.cpp
Expand Up @@ -79,7 +79,7 @@ VerifySignedDigest(const SignedDigest& sd,
return Success;
}

} // unnamed namespace
} // namespace

Result
VerifyRSAPKCS1SignedDigestNSS(const SignedDigest& sd,
Expand Down
2 changes: 1 addition & 1 deletion lib/mozpkix/lib/pkixocsp.cpp
Expand Up @@ -32,7 +32,7 @@ namespace {

const size_t SHA1_DIGEST_LENGTH = 160 / 8;

} // unnamed namespace
} // namespace

namespace mozilla { namespace pkix {

Expand Down
2 changes: 1 addition & 1 deletion lib/mozpkix/test/gtest/pkixder_input_tests.cpp
Expand Up @@ -917,4 +917,4 @@ TEST_F(pkixder_input_tests, MatchRest2Mismatch)
ASSERT_TRUE(input.MatchRest(der));
}

} // unnamed namespace
} // namespace
Expand Up @@ -48,7 +48,7 @@ class OCSPTestTrustDomain : public DefaultCryptoTrustDomain
namespace {
char const* const rootName = "Test CA 1";
void deleteCertID(CertID* certID) { delete certID; }
} // unnamed namespace
} // namespace

class pkixocsp_VerifyEncodedResponse : public ::testing::Test
{
Expand Down
2 changes: 1 addition & 1 deletion lib/mozpkix/test/lib/pkixtestalg.cpp
Expand Up @@ -134,7 +134,7 @@ static const uint8_t DSS_G_RAW[] =
0x62,0xF6,0x35,0x76,
};

} // unnamed namespace
} // namespace

TestSignatureAlgorithm::TestSignatureAlgorithm(
const TestPublicKeyAlgorithm& publicKeyAlg,
Expand Down
4 changes: 2 additions & 2 deletions lib/mozpkix/test/lib/pkixtestnss.cpp
Expand Up @@ -148,7 +148,7 @@ class NSSTestKeyPair final : public TestKeyPair
ScopedSECKEYPrivateKey privateKey;
};

} // unnamed namespace
} // namespace

// This private function is also used by Gecko's PSM test framework
// (OCSPCommon.cpp).
Expand Down Expand Up @@ -216,7 +216,7 @@ GenerateKeyPairInner()
abort();
}

} // unnamed namespace
} // namespace

TestKeyPair*
GenerateKeyPair()
Expand Down
2 changes: 1 addition & 1 deletion lib/mozpkix/test/lib/pkixtestutil.cpp
Expand Up @@ -69,7 +69,7 @@ OpenFile(const string& dir, const string& filename, const string& mode)
return file.release();
}

} // unnamed namespace
} // namespace

bool
InputEqualsByteString(Input input, const ByteString& bs)
Expand Down

0 comments on commit 96ae640

Please sign in to comment.