Skip to content

Commit

Permalink
Bug 1443799 - Update BoGo to a runner that supports draft-23 r=franzi…
Browse files Browse the repository at this point in the history
…skus

Reviewers: franziskus

Reviewed By: franziskus

Bug #: 1443799

Differential Revision: https://phabricator.services.mozilla.com/D696
  • Loading branch information
Tim Taubert committed Mar 8, 2018
1 parent f2d65c8 commit 8b9313b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 4 additions & 0 deletions gtests/nss_bogo_shim/config.json
@@ -1,6 +1,10 @@
{
"DisabledTests": {
"### These tests break whenever we rev versions, so just leave them here for easy uncommenting":"",
"ServerBogusVersion":"Check that SH.legacy_version=TLS12 when the server picks TLS 1.3 (Bug 1443761)",
"DummyPQPadding-Server*":"Boring is testing a dummy PQ padding extension",
"VerifyPreferences-Enforced":"NSS sends alerts in response to errors in protected handshake messages in the clear",
"Draft-Downgrade-Server":"Boring implements a draft downgrade sentinel used for measurements.",
"FilterExtraAlgorithms":"NSS doesn't allow sending unsupported signature algorithms",
"SendBogusAlertType":"Unexpected TLS alerts should abort connections (Bug 1438263)",
"VerifyPreferences-Ed25519":"Add Ed25519 support (Bug 1325335)",
Expand Down
6 changes: 5 additions & 1 deletion gtests/nss_bogo_shim/nss_bogo_shim.cc
Expand Up @@ -262,7 +262,11 @@ class TestAgent {
}

bool SetupOptions() {
SECStatus rv = SSL_OptionSet(ssl_fd_, SSL_ENABLE_SESSION_TICKETS, PR_TRUE);
SECStatus rv =
SSL_OptionSet(ssl_fd_, SSL_ENABLE_TLS13_COMPAT_MODE, PR_TRUE);
if (rv != SECSuccess) return false;

rv = SSL_OptionSet(ssl_fd_, SSL_ENABLE_SESSION_TICKETS, PR_TRUE);
if (rv != SECSuccess) return false;

SSLVersionRange vrange;
Expand Down
2 changes: 1 addition & 1 deletion tests/bogo/bogo.sh
Expand Up @@ -25,7 +25,7 @@ bogo_init()
BORING=${BORING:=boringssl}
if [ ! -d "$BORING" ]; then
git clone -q https://boringssl.googlesource.com/boringssl "$BORING"
git -C "$BORING" checkout -q a513e86c1ebb1383930c9e504bdabcc302a85f30
git -C "$BORING" checkout -q ec55dc15d3a39e5f1a58bfd79148729f38f6acb4
fi

SCRIPTNAME="bogo.sh"
Expand Down

0 comments on commit 8b9313b

Please sign in to comment.