Bug 1274527 - fixing coverity issues found in gtests, r=mt

sailfishos-mirror · May 20, 2016 · 79dee74 · 79dee74
1 parent c39b350
commit 79dee74
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/external_tests/common/gtests.cc b/external_tests/common/gtests.cc
@@ -14,7 +14,9 @@ int main(int argc, char **argv) {
   NSS_SetDomesticPolicy();
   int rv = RUN_ALL_TESTS();
 
-  NSS_Shutdown();
+  if (NSS_Shutdown() != SECSuccess) {
+    return 1;
+  }
 
   return rv;
 }
diff --git a/external_tests/ssl_gtest/tls_agent.cc b/external_tests/ssl_gtest/tls_agent.cc
@@ -51,6 +51,7 @@ TlsAgent::TlsAgent(const std::string& name, Role role, Mode mode)
     expected_version_(0),
     expected_cipher_suite_(0),
     expect_resumption_(false),
+    expect_client_auth_(false),
     can_falsestart_hook_called_(false),
     sni_hook_called_(false),
     auth_certificate_hook_called_(false),

diff --git a/external_tests/ssl_gtest/tls_agent.h b/external_tests/ssl_gtest/tls_agent.h
@@ -378,7 +378,6 @@ class TlsAgentTestBase : public ::testing::Test {
   PRFileDesc* fd_;
   TlsAgent::Role role_;
   Mode mode_;
-  SSLKEAType kea_;
 };
 
 class TlsAgentTest :