Bug 753136 - Fixing ssl3_HandleSupportedPointFormatsXtn, r=ekr

--HG-- extra : rebase_source : bea42936ae26cd59c3967dbe5080c93f9600df0a extra : histedit_source : 813f164605c45563320e0d99b7ad497e7e589a48
sailfishos-mirror · Mar 9, 2015 · 782aec3 · 782aec3
1 parent e61b3a0
commit 782aec3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/ssl/ssl3ecc.c b/lib/ssl/ssl3ecc.c
@@ -1185,8 +1185,7 @@ ssl3_HandleSupportedPointFormatsXtn(sslSocket *ss, PRUint16 ex_type,
 
     if (data->len < 2 || data->len > 255 || !data->data ||
         data->len != (unsigned int)data->data[0] + 1) {
-        /* malformed */
-        goto loser;
+        return ssl3_DecodeError(ss);
     }
     for (i = data->len; --i > 0; ) {
         if (data->data[i] == 0) {
@@ -1197,10 +1196,10 @@ ssl3_HandleSupportedPointFormatsXtn(sslSocket *ss, PRUint16 ex_type,
             return rv;
         }
     }
-loser:
+
     /* evil client doesn't support uncompressed */
     ssl3_DisableECCSuites(ss, ecSuites);
-    return SECFailure;
+    return SECSuccess;
 }