Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Bug 1411500, Check return values in cryptohi_unittest.cc, r=fkiefer
--HG--
extra : amend_source : 71a51ef73ca0e74affff38a46771fb53c14fe454
  • Loading branch information
ueno committed Oct 25, 2017
1 parent 1b6e302 commit 63a9481
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions gtests/cryptohi_gtest/cryptohi_unittest.cc
Expand Up @@ -37,7 +37,9 @@ class SignParamsTestF : public ::testing::Test {
SECOidData *oidData;
oidData = SECOID_FindOIDByTag(SEC_OID_CURVE25519);
ASSERT_NE(nullptr, oidData);
SECITEM_AllocItem(NULL, &ecParams, (2 + oidData->oid.len));
ASSERT_NE(nullptr,
SECITEM_AllocItem(NULL, &ecParams, (2 + oidData->oid.len)))
<< "Couldn't allocate memory for OID.";
ecParams.data[0] = SEC_ASN1_OBJECT_ID; /* we have to prepend 0x06 */
ecParams.data[1] = oidData->oid.len;
memcpy(ecParams.data + 2, oidData->oid.data, oidData->oid.len);
Expand Down Expand Up @@ -67,7 +69,9 @@ class SignParamsTestF : public ::testing::Test {

SECAlgorithmID maskHashAlg;
PORT_Memset(&maskHashAlg, 0, sizeof(maskHashAlg));
SECStatus rv =
SECOID_SetAlgorithmID(arena_.get(), &maskHashAlg, maskHashAlgTag, NULL);
ASSERT_EQ(SECSuccess, rv);

SECItem *maskHashAlgItem =
SEC_ASN1EncodeItem(arena_.get(), NULL, &maskHashAlg,
Expand All @@ -77,7 +81,7 @@ class SignParamsTestF : public ::testing::Test {
arena_.get(), sizeof(SECAlgorithmID));
ASSERT_NE(nullptr, params->maskAlg);

SECStatus rv = SECOID_SetAlgorithmID(arena_.get(), params->maskAlg,
rv = SECOID_SetAlgorithmID(arena_.get(), params->maskAlg,
SEC_OID_PKCS1_MGF1, maskHashAlgItem);
ASSERT_EQ(SECSuccess, rv);
}
Expand Down

0 comments on commit 63a9481

Please sign in to comment.