Bug 1495451 - Fix issues flagged by coverity. r=mt

Tags: #secure-revision Bug #: 1495451 Differential Revision: https://phabricator.services.mozilla.com/D7358
sailfishos-mirror · Oct 2, 2018 · 4a9f579 · 4a9f579
1 parent 6d12b23
commit 4a9f579
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/ssl/tls13con.c b/lib/ssl/tls13con.c
@@ -3449,6 +3449,7 @@ tls13_CopyKeyShareEntry(TLS13KeyShareEntry *o)
 
     if (SECSuccess != SECITEM_CopyItem(NULL, &n->key_exchange, &o->key_exchange)) {
         PORT_Free(n);
+        return NULL;
     }
     n->group = o->group;
     return n;

diff --git a/lib/ssl/tls13exthandle.c b/lib/ssl/tls13exthandle.c
@@ -249,6 +249,7 @@ tls13_ClientHandleKeyShareXtn(const sslSocket *ss, TLSExtensionData *xtnData,
     }
 
     if (SSL_READER_REMAINING(&rdr)) {
+        tls13_DestroyKeyShareEntry(ks);
         PORT_SetError(SSL_ERROR_RX_MALFORMED_KEY_SHARE);
         return SECFailure;
     }
@@ -1310,6 +1311,9 @@ tls13_ServerHandleEsniXtn(const sslSocket *ss, TLSExtensionData *xtnData,
     PRUint64 tmp;
     while (SSL_READER_REMAINING(&sniRdr)) {
         rv = sslRead_ReadNumber(&sniRdr, 1, &tmp);
+        if (rv != SECSuccess) {
+            goto loser;
+        }
         if (tmp != 0) {
             goto loser;
         }