Bug 1351270 - [Coverity 1403257] Don't let ssl_gtests throw exception…

…s in destructors r=mt

Differential Revision: https://nss-review.dev.mozaws.net/D281

--HG--
extra : amend_source : cee9be3ba5c556285cfd353cb36edebc36307810

gtests/ssl_gtest/tls_agent.cc

@@ -89,10 +89,15 @@ TlsAgent::~TlsAgent() {
     Poller::Instance()->Cancel(READABLE_EVENT, adapter_);
   }
 
-  EXPECT_EQ(expected_received_alert_, kTlsAlertCloseNotify);
-  EXPECT_EQ(expected_received_alert_level_, kTlsAlertWarning);
-  EXPECT_EQ(expected_sent_alert_, kTlsAlertCloseNotify);
-  EXPECT_EQ(expected_sent_alert_level_, kTlsAlertWarning);
+  // Add failures manually, if any, so we don't throw in a destructor.
+  if (expected_received_alert_ != kTlsAlertCloseNotify ||
+      expected_received_alert_level_ != kTlsAlertWarning) {
+    ADD_FAILURE() << "Wrong expected_received_alert status";
+  }
+  if (expected_sent_alert_ != kTlsAlertCloseNotify ||
+      expected_sent_alert_level_ != kTlsAlertWarning) {
+    ADD_FAILURE() << "Wrong expected_sent_alert status";
+  }
 }
 
 void TlsAgent::SetState(State state) {