Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Bug 1317017 - Improve logging of TLS 1.3 Finished calculation, r=ekr
--HG--
extra : amend_source : b82d7a0881e4db6b10bc77296f5447e0afdf3cec
  • Loading branch information
martinthomson committed Nov 12, 2016
1 parent 0f4614c commit 2a2505d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/ssl/tls13con.c
Expand Up @@ -3357,7 +3357,9 @@ tls13_ComputeFinished(sslSocket *ss, PK11SymKey *baseKey,
PK11SymKey *secret = NULL;

PORT_Assert(baseKey);
PRINT_BUF(50, (NULL, "Handshake hash", hashes->u.raw, hashes->len));
SSL_TRC(3, ("%d: TLS13[%d]: %s calculate finished",
SSL_GETPID(), ss->fd, SSL_ROLE(ss)));
PRINT_BUF(50, (ss, "Handshake hash", hashes->u.raw, hashes->len));

/* Now derive the appropriate finished secret from the base secret. */
rv = tls13_HkdfExpandLabel(baseKey,
Expand All @@ -3370,7 +3372,6 @@ tls13_ComputeFinished(sslSocket *ss, PK11SymKey *baseKey,
goto abort;
}

PRINT_BUF(50, (NULL, "Handshake hash", hashes->u.raw, hashes->len));
PORT_Assert(hashes->len == tls13_GetHashSize(ss));
hmacCtx = PK11_CreateContextBySymKey(macAlg, CKA_SIGN,
secret, &param);
Expand Down

0 comments on commit 2a2505d

Please sign in to comment.