Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
gl: download: Fix a caps memory leak in prepare_output_buffer().
  • Loading branch information
HeJunyan authored and GStreamer Marge Bot committed Mar 3, 2021
1 parent 2f3033c commit f506a3e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion ext/gl/gstgldownloadelement.c
Expand Up @@ -484,6 +484,7 @@ gst_gl_download_element_prepare_output_buffer (GstBaseTransform * bt,
} else {
GstCaps *src_caps;
GstCapsFeatures *features;
gboolean ret;

src_caps = gst_pad_get_current_caps (bt->srcpad);
src_caps = gst_caps_make_writable (src_caps);
Expand All @@ -492,7 +493,10 @@ gst_gl_download_element_prepare_output_buffer (GstBaseTransform * bt,
g_atomic_int_set (&dl->try_dmabuf_exports, FALSE);
dl->mode = GST_GL_DOWNLOAD_MODE_PBO_TRANSFERS;

if (!gst_base_transform_update_src_caps (bt, src_caps)) {
ret = gst_base_transform_update_src_caps (bt, src_caps);
gst_caps_unref (src_caps);

if (!ret) {
GST_ERROR_OBJECT (bt, "DMABuf exportation didn't work and system "
"memory is not supported.");
return GST_FLOW_NOT_NEGOTIATED;
Expand Down

0 comments on commit f506a3e

Please sign in to comment.