Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
multihandlesink: Don't pass NULL caps to gst_caps_is_equal
Apparently the sinkpad caps can get cleared when shutting down the
pipeline while the sink is working, provoking a critical warning.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/857>
  • Loading branch information
heftig authored and tp-m committed Oct 10, 2020
1 parent 5be4e5d commit ed36a63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gst/tcp/gstmultihandlesink.c
Expand Up @@ -966,7 +966,7 @@ gst_multi_handle_sink_client_queue_buffer (GstMultiHandleSink * mhsink,
}
} else {
/* there were previous caps recorded, so compare */
if (!gst_caps_is_equal (caps, mhclient->caps)) {
if (caps && !gst_caps_is_equal (caps, mhclient->caps)) {
const GValue *sh1, *sh2;

/* caps are not equal, but could still have the same streamheader */
Expand Down

0 comments on commit ed36a63

Please sign in to comment.