Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
audioaggregator: fix input_buffer ownership
The way pad->priv->input_buffer reference was managed was pretty spurious: - it was overridden without unrefing it, which could potentially lead to leaks. - we were unreffing it while keeping the pointer around, which could potentially lead to use-after-free or double-free. As priv->input_buffer is actually no longer used outside of the aggregate() method, remove it from pad->priv to simplify the code and prevent the issues desribed above. Fix a single buffer leak when shutting down the pipeline as the buffer returned from gst_aggregator_pad_drop_buffer() was never unreffed. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1061>
- Loading branch information
Guillaume Desmottes
committed
Mar 10, 2021
1 parent
44358f1
commit b7c1810
Showing
1 changed file
with
7 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters