Skip to content

Commit

Permalink
playback: element_init returns void
Browse files Browse the repository at this point in the history
no need to return boolean as it will
be always TRUE.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1029>
  • Loading branch information
Stéphane Cerveau authored and GStreamer Marge Bot committed Mar 16, 2021
1 parent d8e00a4 commit a750bc8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gst/playback/gstplaybackelement.c
Expand Up @@ -36,10 +36,11 @@
#include "gstplaybackelements.h"


gboolean
void
playback_element_init (GstPlugin * plugin)
{
static gsize res = FALSE;

if (g_once_init_enter (&res)) {
gst_pb_utils_init ();

Expand All @@ -51,5 +52,4 @@ playback_element_init (GstPlugin * plugin)
#endif /* ENABLE_NLS */
g_once_init_leave (&res, TRUE);
}
return res;
}
2 changes: 1 addition & 1 deletion gst/playback/gstplaybackelements.h
Expand Up @@ -39,6 +39,6 @@ GST_ELEMENT_REGISTER_DECLARE (parsebin);
gboolean gst_play_bin_custom_element_init (GstPlugin * plugin);
gboolean gst_play_bin3_custom_element_init (GstPlugin * plugin);

G_GNUC_INTERNAL gboolean playback_element_init (GstPlugin * plugin);
G_GNUC_INTERNAL void playback_element_init (GstPlugin * plugin);

#endif /* __GST_PLAY_BACK_ELEMENTS_H__ */
2 changes: 1 addition & 1 deletion gst/playback/gstplaybin3.c
Expand Up @@ -5154,7 +5154,7 @@ gst_play_bin3_custom_element_init (GstPlugin * plugin)

GST_DEBUG_CATEGORY_INIT (gst_play_bin3_debug, "playbin3", 0, "play bin3");

ret &= playback_element_init (plugin);
playback_element_init (plugin);

if (g_getenv ("USE_PLAYBIN3"))
ret &= gst_element_register (plugin, "playbin", GST_RANK_NONE,
Expand Down

0 comments on commit a750bc8

Please sign in to comment.