gst-play: use Fisher-Yates shuffle for shuffling the playlist

sailfishos-mirror · Aug 10, 2018 · 7e9d672 · 7e9d672
1 parent 0340c7e
commit 7e9d672
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tools/gst-play.c b/tools/gst-play.c
@@ -817,9 +817,9 @@ shuffle_uris (gchar ** uris, guint num)
   if (num < 2)
     return;
 
-  for (i = 0; i < num; i++) {
-    /* gets equally distributed random number in 0..num-1 [0;num[ */
-    j = g_random_int_range (0, num);
+  for (i = num - 1; i >= 1; i--) {
+    /* +1 because number returned will be in range [a;b[ so excl. stop */
+    j = g_random_int_range (0, i + 1);
     tmp = uris[j];
     uris[j] = uris[i];
     uris[i] = tmp;