Skip to content

Commit

Permalink
typefindfunctions: lower H.263 typefinder max probability
Browse files Browse the repository at this point in the history
The typefinder returns LIKELY for as little as one possible
sync and no bad sync (not even taking into account how much
data was looked at for that). It's generally just not fit
for purpose, so should just not return anything like LIKELY
at all ever, even more so since it only recognises one out
of ten H263 files, and likes to mis-detect mp3s as H263.

https://bugzilla.gnome.org/show_bug.cgi?id=700770
https://bugzilla.gnome.org/show_bug.cgi?id=725644
  • Loading branch information
tp-m committed Mar 5, 2014
1 parent 4220442 commit 61fa4c7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions gst/typefind/gsttypefindfunctions.c
Expand Up @@ -2587,9 +2587,9 @@ h263_video_type_find (GstTypeFind * tf, gpointer unused)
data_scan_ctx_advance (tf, &c, 1);
}

if (good > 0 && bad == 0)
gst_type_find_suggest (tf, GST_TYPE_FIND_LIKELY, H263_VIDEO_CAPS);
else if (good > 2 * bad)
GST_LOG ("good: %d, bad: %d", good, bad);

if (good > 2 * bad)
gst_type_find_suggest (tf, GST_TYPE_FIND_POSSIBLE, H263_VIDEO_CAPS);

return;
Expand Down

0 comments on commit 61fa4c7

Please sign in to comment.