Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
rtpbasedepay: fix locking of GstRTPHeaderExtension
'ext' object unlocked if gst_rtp_header_extension_read() fails was never
locked in the first place.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1118>
  • Loading branch information
xhaakon committed Apr 21, 2021
1 parent 7434608 commit 538e2ef
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gst-libs/gst/rtp/gstrtpbasedepayload.c
Expand Up @@ -1233,6 +1233,7 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
}

if (ext) {
GST_OBJECT_LOCK (ext);
if (!gst_rtp_header_extension_read (ext, ext_flags, &pdata[offset],
read_len, output)) {
GST_WARNING_OBJECT (depayload, "RTP header extension (%s) could "
Expand All @@ -1246,6 +1247,7 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
needs_src_caps_update = TRUE;
}

GST_OBJECT_UNLOCK (ext);
gst_object_unref (ext);
}
GST_OBJECT_UNLOCK (depayload);
Expand Down

0 comments on commit 538e2ef

Please sign in to comment.