Commit 538e2ef1 authored by Jakub Adam's avatar Jakub Adam

rtpbasedepay: fix locking of GstRTPHeaderExtension

'ext' object unlocked if gst_rtp_header_extension_read() fails was never
locked in the first place.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1118>
parent 74346080
......@@ -1233,6 +1233,7 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
}
if (ext) {
GST_OBJECT_LOCK (ext);
if (!gst_rtp_header_extension_read (ext, ext_flags, &pdata[offset],
read_len, output)) {
GST_WARNING_OBJECT (depayload, "RTP header extension (%s) could "
......@@ -1246,6 +1247,7 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
needs_src_caps_update = TRUE;
}
GST_OBJECT_UNLOCK (ext);
gst_object_unref (ext);
}
GST_OBJECT_UNLOCK (depayload);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment