Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
libvisual: use gst_element_class_set_metadata when passing dynamic st…
…rings

gst_element_class_set_metadata is meant to only be used with
static or inlined strings, which isn't the case for this element
resulting in use-after-free later on.

https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/871>
  • Loading branch information
alatiera authored and tp-m committed Oct 14, 2020
1 parent c1b4b0f commit 53432a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/libvisual/visual.c
Expand Up @@ -106,7 +106,7 @@ gst_visual_class_init (gpointer g_class, gpointer class_data)
gst_element_class_add_static_pad_template (element_class, &src_template);
gst_element_class_add_static_pad_template (element_class, &sink_template);

gst_element_class_set_static_metadata (element_class,
gst_element_class_set_metadata (element_class,
longname, "Visualization",
klass->plugin->info->about, "Benjamin Otte <otte@gnome.org>");

Expand Down

0 comments on commit 53432a5

Please sign in to comment.