diff --git a/gst-libs/gst/rtp/gstrtpbasepayload.c b/gst-libs/gst/rtp/gstrtpbasepayload.c index 8be9df36f..dc4fdd9c1 100644 --- a/gst-libs/gst/rtp/gstrtpbasepayload.c +++ b/gst-libs/gst/rtp/gstrtpbasepayload.c @@ -1765,6 +1765,11 @@ set_headers (GstBuffer ** buffer, guint idx, gpointer user_data) (GFunc) write_header_extension, &hdrext); wordlen = hdrext.written_size / 4 + ((hdrext.written_size % 4) ? 1 : 0); + + /* zero-fill the hdrext padding bytes */ + memset (&hdrext.data[hdrext.written_size], 0, + wordlen * 4 - hdrext.written_size); + gst_rtp_buffer_set_extension_data (&rtp, bit_pattern, wordlen); } GST_OBJECT_UNLOCK (data->payload); diff --git a/gst-libs/gst/rtp/gstrtpbuffer.c b/gst-libs/gst/rtp/gstrtpbuffer.c index ae519f313..739b7d96f 100644 --- a/gst-libs/gst/rtp/gstrtpbuffer.c +++ b/gst-libs/gst/rtp/gstrtpbuffer.c @@ -856,15 +856,23 @@ gst_rtp_buffer_set_extension_data (GstRTPBuffer * rtp, guint16 bits, mem = gst_allocator_alloc (NULL, min_size, NULL); if (rtp->data[1]) { - /* copy old data */ + /* copy old data & initialize the remainder of the new buffer */ gst_memory_map (mem, &map, GST_MAP_WRITE); memcpy (map.data, rtp->data[1], rtp->size[1]); + if (min_size > rtp->size[1]) { + memset (map.data + rtp->size[1], 0, min_size - rtp->size[1]); + } gst_memory_unmap (mem, &map); /* unmap old */ gst_buffer_unmap (rtp->buffer, &rtp->map[1]); gst_buffer_replace_memory (rtp->buffer, 1, mem); } else { + /* don't leak data from uninitialized memory via the padding */ + gst_memory_map (mem, &map, GST_MAP_WRITE); + memset (map.data, 0, map.size); + gst_memory_unmap (mem, &map); + /* we didn't have extension data, add */ gst_buffer_insert_memory (rtp->buffer, 1, mem); }