Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
audioaggregator: fix input buffer when converting
This code path is meant to convert the current buffer to the new format
on update. It was using priv->input_buffer as input which is either
priv->buffer or a converted version of it.
Use priv->buffer instead as priv->input_buffer may no longer be a valid
reference.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1061>
  • Loading branch information
Guillaume Desmottes committed Mar 10, 2021
1 parent e135961 commit 44358f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gst-libs/gst/audio/gstaudioaggregator.c
Expand Up @@ -1071,7 +1071,7 @@ gst_audio_aggregator_update_converters (GstAudioAggregator * aagg,
if (aaggpad->priv->buffer) {
GstBuffer *new_converted_buffer =
gst_audio_aggregator_convert_buffer (aagg, GST_PAD (aaggpad),
old_info, new_info, aaggpad->priv->input_buffer);
old_info, new_info, aaggpad->priv->buffer);
gst_buffer_replace (&aaggpad->priv->buffer, new_converted_buffer);
gst_buffer_unref (new_converted_buffer);
}
Expand Down

0 comments on commit 44358f1

Please sign in to comment.