Skip to content

Commit

Permalink
alsadeviceprovider: Remove redundant start function
Browse files Browse the repository at this point in the history
The ALSA provider doesn't provider live monitoring, so don't
pretend otherwise.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/735>
  • Loading branch information
ocrete authored and GStreamer Merge Bot committed Jul 20, 2020
1 parent e762f1b commit 2de70ed
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions ext/alsa/gstalsadeviceprovider.c
Expand Up @@ -92,8 +92,6 @@ add_device (GstDeviceProvider * provider, snd_ctl_t * info,

snd_pcm_close (handle);

gst_device_provider_device_add (provider, gst_object_ref (device));

return device;
}

Expand Down Expand Up @@ -169,23 +167,6 @@ gst_alsa_device_provider_probe (GstDeviceProvider * provider)
}


static gboolean
gst_alsa_device_provider_start (GstDeviceProvider * provider)
{
g_list_free_full (gst_alsa_device_provider_probe (provider),
gst_object_unref);

/* TODO - Implement monitoring support */

return TRUE;
}

static void
gst_alsa_device_provider_stop (GstDeviceProvider * provider)
{
return;
}

enum
{
PROP_0,
Expand All @@ -199,8 +180,6 @@ gst_alsa_device_provider_class_init (GstAlsaDeviceProviderClass * klass)
GstDeviceProviderClass *dm_class = GST_DEVICE_PROVIDER_CLASS (klass);

dm_class->probe = gst_alsa_device_provider_probe;
dm_class->start = gst_alsa_device_provider_start;
dm_class->stop = gst_alsa_device_provider_stop;

gst_device_provider_class_set_static_metadata (dm_class,
"ALSA Device Provider", "Sink/Source/Audio",
Expand Down

0 comments on commit 2de70ed

Please sign in to comment.