[usb-moded] Add support for removing user config. Fixes JB#50129

See merge request !62

Autogenerate D-Bus introspect and busconfig XML

See merge request !61

After years of manual editing, method calls and signals are
listed in more or less random order.

Arrange members so that methods are listed before signals and,
in both groups related entries are next to each other.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Some errors have crept in usb-moded introspect and busconfig files,
e.g. typos in method names and accidentally making all method calls
available for everybody.

Use object-interface-member lookup tables both for handling incoming
method calls and automatically generating introspect / configuration
data.

Add usb_moded commandline options
  -I --dbus-introspect-xml
  -B --dbus-busconfig-xml
for outputting autogenerated configuration data.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Whitespace in logging is stripped anyway and outputting trailing
spaces for --help lines does not make any sense either.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

[config] Set and get user specific mode. Fixes JB#49457

See merge request !60

Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Use device owner's config as a fallback if user doesn't have a mode set.
Prevent getting or setting invalid modes, i.e. those that are either not
whitelisted or not permitted, falling back to MODE_ASK.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Use the actual current user on seat0 to select modes. This will prevent
accidental or malicious ways to trick user to use other user's mode.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Define PID_UNKNOWN too while at it.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Previously non-dynamic modes were allowed even in case of UID_UNKNOWN.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

This is basically a requirement to get uids and login management right.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Allow mtp for users group

See merge request !59

Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Allow mtp for users group.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Use group from configuration to test if user is allowed to use dynamic
mode.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

This adds configuration group mode_group that can be used to specify
which groups may use a dynamic mode. Defaults to "sailfish-system"
meaning only device owner and value "users" means everyone.
Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>

Define TEMP_FAILURE_RETRY on non-glibc systems

See merge request !57

This makes it work for example on Musl systems

Systemd sandboxing and connection sharing fixes

See merge request !56

Network sharing via connman does not work in all devices, legacy sharing
config not ivolving connman works in no devices. Part of the problem lies
in connman/kernel end (device type for rndis0 interface is not reported by
udev and/or connman developer mode plugin does not take connection sharing
mode into account), part is due to fragile / broken usb-moded side logic.

Stop usb-moded from making wifi / cellular power cycle requests.

When using legacy sharing config and cellular is not online, make an
attempt to share wlan connection (the connman way already does this).

Rewrite all D-Bus ipc logic and refactor the rest too.

Add error checks in select places so that usb-moded abandons failed
mode setting and falls back to charging only.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Using vanilla libdbus api for dealing with messages containing
variants and dict arrays can be cumbersome.

Add helper functionality to avoid complexity elsewhere.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Avoid literal buffer sizes, remove unnecessary trailing whitespace,
and use correct data types.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Attribute making it possible for gcc to check logging format strings
vs. arguments given got dropped at some stage.

Put __attribute__((format(printf,...))) back in.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

When logging to stderr from usb-moded systemd service (e.g. due to slightly
different logging format) block buffering is used and causes the messages
to appear out of sync vs other processes.

Flush stderr after each diagnostic message.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Compiler diagnostics have improved. Using PATH_MAX buffer sizes when
constructing paths with snprintf() and friends both makes sense and keeps
gcc happier.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Development time ini-file merge logging that got left in. Generates enough
noise to make debug logging useless for normal purposes.

Comment out uninteresting progress messages.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Attempting to remove a file from read-only filesystem yields
EROFS error even if the file does not exist. Which then leads
usb-moded complaining about not being able to remove a file
that does not exist.

Check that legacy config file /etc/usb-moded/usb-moded.ini
exist before attempting to remove it.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

The return value from system() is wait() like status value - not subprocess
exit code.

Fix return value handling and improve diagnostic output while at it.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Apparently refactoring from integer 0/-1 to boolean true/false
return value went slightly wrong - some call sites were not
adjusted accordingly.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Compiler warns about "const const".
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Usb-moded is running as root, with full capability set.

Define and use minimal set of capabilities required by usb-moded to
operate correctly on all supported devices.

Document further sandboxing actions that should be made, but are not
possible with the systemd version that is currently available in
sailfish.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Temporarily disabling generation of doxygen documentation can significantly
reduce time taken by full rebuilds. However, it also makes rpm build fail
due to not having any html documents to install / package after build step.

Produce empty doc package if no html files have been generated during
build step.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>