Handle comma separated list of configfs functions

See merge request !54

In android-usb backend a comma separated list of functions to enabled
can be written as-is to sysfs control file. This assumption got inherited
by configfs backend, and things fall apart if a mode needs to activate
more than one function.

Split comma separated list of functions into an array and enable each
function separately.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Don't use %config(noreplace).

See merge request !53

[packaging] Update config as per policy. Contributes JB#44152
Signed-off-by: David Greaves <david.greaves@jolla.com>

Fix handling of fallback setting values

See merge request !50

For the purpose of preserving runtime modifications values in legacy
configuration files need to be given priority over new style static
configuration files. As a side effect this makes it impossible to
override default mode if it was done via defining mode=ask in the
legacy config file.

Ignore mode=ask if defined in a legacy config file.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Having developer is optional and requires configuration files to be
installed on the device. Thus defaulting to use developer mode in
absence of any configuration files makes little sense, and also causes
need for otherwise unnecessary configuration files in normal user
devices.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Runtime configuration changes are saved as "delta to values defined in
static configuration". Handling default values separately from static
configuration can cause unexpected values to get stuck on save.

Seed static configuration data with assumed defaults to rectify behavior
of delta save logic.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

[usb-moded] Proper use of ifconfig command. Contributes to JB#45772

See merge request !49

Use 'ifconfig <interface> <ip> netmask <netmask>' format when calling
ifconfig from usb-moded. This is the proper use according to ifconfig
manual pages. When adding a netmask, keyword 'netmask' is instructed to
be used.

Fix data corruption after SIGHUP config reload

See merge request !48

Changing setting values and broadcasting changes on D-Bus are handled
separately. This leads to a situation where some code paths that modify
settings do it silently without sending D-Bus notifications.

Send setting change notification from configuration layer, so that each
and every setting change does result in D-Bus notification signal.

Remove all case-by-case signal emitting code made redundant by these
changes.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

While the worker thread already caches private copy of mode data,
acquiring this private copy is hazardous due to iterating list owned
by the main thread.

Add usbmoded_dup_modedata() function that does the list iteration and
duplication while holding mutex, and utilize it for looking up mode
data from the worker thread.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

The currently active mode data is owned by the worker thread. Accessing it
from the main thread is not safe.

Add worker_dup_usb_mode_data() function for getting copy of the currently
active mode data in thread safe manner and utilize it from functions that
might get called from the main thread too.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Removing dynamic mode configuration files can invalidate default mode
setting and/or currently active mode.

If currently selected default mode is no longer available after
configuration file refresh, select "ask" as default mode.

If currently active mode is no longer available after configuration file
refresh, re-evaluate appropriate mode similarly as what is done on cable
connect.

Also document mode names in a bit more detail.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

When a dynamic mode is activated from the worker thread, a pointer to
shared mode data is cached. If mode data gets invalidated due to the main
thread reloading configuration files, the worker thread will dereference
a stale pointer during mode deactivation.

Cache clone of mode data instead of just holding pointer to shared data.

Note that this only fixes logical error in expected behavior during
config reload, there is still race condition in mode data duplication
stage.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Replace custom mode list iterators with a call to common function.

Also fix compilation warnings resulting from mode data pointers now
being marked as const.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Iterating mode lists is cumbersome and might not be safe when done from
the worker thread.

As an enabler for removing custom list iterators, implement common
usbmoded_get_modedata() function for locating mode data by name.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Enabler for having privately owned mode data in the worker thread.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

String fields in modedata_t structures are filled in via functions that
return 'gchar *' pointers - adjust structure data types and release
function accordingly.

The modelist_free() function uses g_list_foreach() iterator and a
callback function that is not appropriate for the action, and then uses
a cast to hide any compiler warnings - get rid of the cast by using
g_list_free_full() iterator and a suitable callback function.

The modelist_load() function looks complex and indiscriminately loads
all files from dynamic mode configuration directory. If there are for
example editor backup files present, this can lead to hard to detect
issues - simplify the logic and use glob pattern expansion to derive
list of files to load.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Move functions of the same type close to each other.

No functional changes.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Add Doxygen comments.

No functional changes.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

The important part is that these structures contain mode data, not
that they are also held in lists - make the naming reflect this.

Also rename related functions accordingly.

No functional changes.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Update function declaration lists.

Fix some misnomers / typos in function names.

No functional changes.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Bug reference was missing from commit set and bots rejected the build.

[dbus] Add Qt specific annotation to usb-moded Introspect XML. JB#43928

Add Qt specific annotation to usb-moded D-Bus Introspect XML

See merge request !47

Attempting to generate code from usb-moded introspect data with
qdbusxml2cpp fails because "a{sv}" is by design mystery to it.

Add annotation to tell qdbusxml2cpp that "a{sv}" is QVariantMap.

And add couple of missing "\n" chars while at it.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Expose dynamic mode configuration on D-Bus

See merge request !46

When usb-moded causes network interfaces to be brought up/down, firewall
rules should be adjusted accordingly. However currently there is no way
for connman to know which interface changes might be related to for
example developer mode activation.

Expose dynamic usb mode configuration (attributes relevant to connman)
on D-Bus.

Broadcast a signal whenever target mode changes (mode transition begins,
or fallback mode gets activated due to mode transition errors).

Also provide a method call for querying the current target configuration.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Stop writing to /etc and add settings for configfs details

See merge request !45

Use backend_init() and backend_quit() functions for settings up and
cleaning up all backends.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

Configfs support was orginally developed in Sony XA2 context. Now it turns
out some details need tweaking to make it work with other devices.

Make location of configfs control file hierarchy, configuration and
functions to use tweakable via usb-moded configuration files.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>

While combining all configuration data into /etc/usb-moded/usb-moded.ini
works as expected when new configuration files are installed to the device,
it also means that 1) uninstalling / updating configuration files has no
effect and 2) /etc can't reside on a read-only file-system.

Maintain "delta to static configuration" and store it outside /etc - in
/var/lib/usb-moded/usb-moded.ini, so that also changes in / removal of
existing configuration files are handled in deterministic manner.

If /etc/usb-moded/usb-moded.ini exists, migrate data from it and then remove
the now unnecessary file.

Streamline handling of non-existing configuration and remove functions made
redundant in the process.

Note: The "read from filesystem on each setting access" is retained for now
to avoid regression is situations where such behavior might be expected.
Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>